fix: clarify policy sync status indicators - #97
Merged
AlexanderLanin merged 3 commits intoSep 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The open-PR “badge-only” rendering currently falls back to showing an X when the PR URL is missing/invalid, which can contradict the intended status presentation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR refines the policy-sync dashboard’s visual status indicators so “open policy PR” becomes a distinct actionable state, and violations/errors use clearer red X markers instead of !.
Changes:
- Updated status markers in the policy-sync summary and matrix cells from
!toXfor “Changes Needed” and error states. - Adjusted matrix rendering to show repositories with an open policy PR as an “Open” badge-only state.
- Updated CSS to style open PR badges in orange and error statuses in red.
File summaries
| File | Description |
|---|---|
tests/test_policy_sync.py |
Updates regression assertions for new marker/badge rendering and CSS expectations. |
src/generate_repo_overview/templates/styles.css |
Tweaks policy-sync status and PR badge colors (open → orange; error → red). |
src/generate_repo_overview/_policy_sync_html.py |
Changes rendered markers to X and adds logic to render open policy PR cells as badge-only. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MaximilianSoerenPollak
previously approved these changes
Sep 2, 2026
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Ì like the new way quiet a bit more. Good change.
MaximilianSoerenPollak
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Clarifies policy-sync dashboard status indicators so repositories with an open policy PR are shown as an actionable state between noncompliant and compliant. Replacing exclamation marks with red X markers also makes violations and errors unambiguous.
Changes
Openbadge.Xmarkers for changes needed and evaluation or sync errors.