Fix aspect lint findings - #949
Open
sergejwinterbmw wants to merge 1 commit into
Open
Conversation
sergejwinterbmw
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
August 18, 2026 09:47
sergejwinterbmw
force-pushed
the
sw/score/lint_findings
branch
from
August 18, 2026 11:32
cb05f09 to
6f5da37
Compare
LittleHuba
reviewed
Aug 18, 2026
Comment on lines
+47
to
+56
| const_iterator begin() const noexcept | ||
| { | ||
| return cbegin(); | ||
| } | ||
|
|
||
| const_iterator end() const noexcept | ||
| { | ||
| return cend(); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Should these not return iterator?
Contributor
There was a problem hiding this comment.
I believe it was a very intentional design that this map view does not allow you to get none const iterators.
I would make begin() const to return const_iterator even if this is not fulfilling container requirements.
We are anyway as of today not fulfilling container requirements by not providing begin() and end()
sergejwinterbmw
force-pushed
the
sw/score/lint_findings
branch
from
August 18, 2026 11:49
6f5da37 to
b86effe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.