fix: metrics.json could use more data - #722
Open
Mr-Neutr0n wants to merge 1 commit into
Open
Conversation
Signed-off-by: Mr-Neutr0n <64578610+Mr-Neutr0n@users.noreply.github.com>
Mr-Neutr0n
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
August 17, 2026 06:11
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
Member
|
Hi @Mr-Neutr0n thanks for the contribution! I didn't look deeply into it yet, but doesn't it overlap with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #685
Added a small, documented
needs_overview(total/external/local/by_type) to the generic metrics.json, updated its JSON schema, added tests, and documented it — the issue's guidance (no arbitrary data, hard to remove fields) was treated as instruction, not followed literally into an arbitrary dump.Could not run the suite locally: /config/init.py:2234. Fork CI needs a maintainer approval to run, so this branch has no test signal yet.
This change was prepared with AI assistance under human direction and review.