Implement maven lookup exclusion to sbom plugin - #6296
Open
DieterMai wants to merge 2 commits into
Open
Conversation
merks
approved these changes
Sep 7, 2026
merks
left a comment
merks
left a comment
Contributor
There was a problem hiding this comment.
Thanks so much for taking care of the whole end-to-end support for this option!
| if (trim.isEmpty()) { | ||
| continue; | ||
| } | ||
| getLog().debug("Add content redirection: "+trim); |
Contributor
There was a problem hiding this comment.
If we were really picked, we'd complain about the lack of whitespace around the +. 😁
Test Results1 065 files 1 065 suites 5h 32m 14s ⏱️ Results for commit b42313a. ♻️ This comment has been updated with latest results. |
Member
|
@merks Feel free to merge if you are fine with the change. |
Contributor
|
Crappy. The update did a merge and not a rebase. 😱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implemented maven lookup exclusion. This was implemented into p2repo-sbom with
eclipse-cbi/p2repo-sbom#34
as a reaction to
eclipse-cbi/p2repo-sbom#33
How was this tested?
It was tested locally with the setup that otherwise failed.
No automated tests.
AI/GenAI disclosure
No character was written by an LLM
Checklist
mvn clean install -DskipTests/ relevant integration tests pass locally.