Remove maven-compat dependency - #6345
Merged
Merged
Conversation
No Tycho source uses a class or Plexus component that only maven-compat provides. It was added for maven-plugin-testing-harness 2.0, which required it; the 3.5.1 version in use no longer does. tycho-p2-repository-plugin uses maven-core in its mojos but only got it onto the compile classpath through the test-scoped maven-compat, because the root pom manages maven-core as provided. Declare it directly like the other mojo modules do. Assisted-by: Anthropic Claude Code (claude-fable-5-1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No Tycho source uses a class or Plexus component that only maven-compat provides. It was added for maven-plugin-testing-harness 2.0, which required it; the 3.5.1 version in use no longer does.
tycho-p2-repository-plugin uses maven-core in its mojos but only got it onto the compile classpath through the test-scoped maven-compat, because the root pom manages maven-core as provided. Declare it directly like the other mojo modules do.
Assisted-by: Anthropic Claude Code (claude-fable-5-1)