[EuiPopover] Round title and footer corners to match the panel - #9985
Open
ryankeairns wants to merge 3 commits into
Open
[EuiPopover] Round title and footer corners to match the panel#9985ryankeairns wants to merge 3 commits into
ryankeairns wants to merge 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a low-risk, self-contained styling adjustment that aligns title/footer visuals with the existing panel radius (only a minor comment wording nit noted).
Pull request overview
Updates EuiPopoverTitle and EuiPopoverFooter styling so their backgrounds respect the same corner radius as the popover panel, preventing title/footer fills from visually “squaring off” rounded panel corners (per #9970).
Changes:
- Applied
euiTheme.border.radius.mediumto the title’s top corners. - Applied
euiTheme.border.radius.mediumto the footer’s bottom corners. - Added an upcoming changelog entry documenting the visual bugfix.
File summaries
| File | Description |
|---|---|
| packages/eui/src/components/popover/popover_title.styles.ts | Rounds the title’s top corners to match the popover panel radius. |
| packages/eui/src/components/popover/popover_footer.styles.ts | Rounds the footer’s bottom corners to match the popover panel radius. |
| packages/eui/changelogs/upcoming/9985.md | Documents the popover title/footer radius bugfix in the changelog. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mgadewoll
self-requested a review
September 2, 2026 06:17
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
mgadewoll
approved these changes
Sep 2, 2026
mgadewoll
left a comment
Contributor
There was a problem hiding this comment.
🟢 Changes are LGTM. Thanks for the fix!
💚 Build Succeeded
History
|
💚 Build Succeeded
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9970
Summary
EuiPopoverTitleandEuiPopoverFooternow use the same corner radius as the popover panel.border.radius.mediumto the title’s top corners and the footer’s bottom corners. Do not addoverflow: hiddenon the panel — that clips the filter-based shadow and arrow.API Changes
None.
Screenshots
Impact Assessment
Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.
EuiInputPopover). No layout or API change.Impact level: 🟢 Low
Release Readiness
N/A — visual bugfix, no docs changeN/AN/AN/AQA instructions for reviewer
EuiPopoverFooter(andEuiPopoverTitle) a background color.panelPaddingSize="none".Checklist before marking Ready for Review
N/Abreaking changelabel (if applicable)N/AReviewer checklist