Skip to content

[EuiPopover] Round title and footer corners to match the panel - #9985

Open
ryankeairns wants to merge 3 commits into
mainfrom
rk/well-rounded
Open

[EuiPopover] Round title and footer corners to match the panel#9985
ryankeairns wants to merge 3 commits into
mainfrom
rk/well-rounded

Conversation

@ryankeairns

@ryankeairns ryankeairns commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Closes #9970

Summary

  • What: EuiPopoverTitle and EuiPopoverFooter now use the same corner radius as the popover panel.
  • Why: Fixes [EuiPopoverFooter] Footer background is not clipped to the popover panel border radius #9970. A title or footer background currently squares off the panel corners. This gets more obvious once panel radius increases.
  • How: Apply border.radius.medium to the title’s top corners and the footer’s bottom corners. Do not add overflow: hidden on the panel — that clips the filter-based shadow and arrow.

API Changes

None.

Screenshots

Before After
CleanShot 2026-09-01 at 15 44 06@2x CleanShot 2026-09-01 at 15 38 52@2x
CleanShot 2026-09-01 at 15 37 26@2x CleanShot 2026-09-01 at 15 38 18@2x

Impact Assessment

Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.

  • 🔴 Breaking changes — What will break? How many usages in Kibana/Cloud UI are impacted?
  • 💅 Visual changes — Title/footer fills now follow the panel radius. Visible when those regions have a background (e.g. Kibana options list EuiInputPopover). No layout or API change.
  • 🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).
  • 🔧 Hard to integrate — If changes require substantial updates to Kibana, please stage the changes and link them here.

Impact level: 🟢 Low

Release Readiness

  • Documentation: N/A — visual bugfix, no docs change
  • Figma: N/A
  • Migration guide: N/A
  • Adoption plan (new features): N/A

QA instructions for reviewer

  • Open Storybook EuiPopoverFooter and EuiPopoverTitle.
  • Give EuiPopoverFooter (and EuiPopoverTitle) a background color.
  • Bottom corners of the footer follow the panel radius (not square).
  • Top corners of the title follow the panel radius (not square).
  • Filter shadow and arrow still render (no clipping).
  • Repeat on Layout / EuiInputPopover with a footer background, including panelPaddingSize="none".

Checklist before marking Ready for Review

  • Filled out all sections above
  • QA: Tested light/dark modes, high contrast, mobile, Chrome/Safari/Edge/Firefox, keyboard-only, screen reader
  • QA: Tested in CodeSandbox and Kibana
  • QA: Tested docs changes N/A
  • Tests: Existing Jest snapshots still pass (class names unchanged)
  • Changelog: Added changelog entry
  • Breaking changes: Added breaking change label (if applicable) N/A

Reviewer checklist

  • Approved Impact Assessment — Acceptable to merge given the consumer impact.
  • Approved Release Readiness — Docs, Figma, and migration info are sufficient to ship.

ryankeairns and others added 2 commits September 1, 2026 15:36
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ryankeairns
ryankeairns marked this pull request as ready for review September 1, 2026 22:45
@ryankeairns
ryankeairns requested a review from a team as a code owner September 1, 2026 22:45
Copilot AI lite review requested due to automatic review settings September 1, 2026 22:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a low-risk, self-contained styling adjustment that aligns title/footer visuals with the existing panel radius (only a minor comment wording nit noted).

Pull request overview

Updates EuiPopoverTitle and EuiPopoverFooter styling so their backgrounds respect the same corner radius as the popover panel, preventing title/footer fills from visually “squaring off” rounded panel corners (per #9970).

Changes:

  • Applied euiTheme.border.radius.medium to the title’s top corners.
  • Applied euiTheme.border.radius.medium to the footer’s bottom corners.
  • Added an upcoming changelog entry documenting the visual bugfix.
File summaries
File Description
packages/eui/src/components/popover/popover_title.styles.ts Rounds the title’s top corners to match the popover panel radius.
packages/eui/src/components/popover/popover_footer.styles.ts Rounds the footer’s bottom corners to match the popover panel radius.
packages/eui/changelogs/upcoming/9985.md Documents the popover title/footer radius bugfix in the changelog.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/eui/src/components/popover/popover_footer.styles.ts Outdated
@mgadewoll
mgadewoll self-requested a review September 2, 2026 06:17
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@mgadewoll mgadewoll left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Changes are LGTM. Thanks for the fix!

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EuiPopoverFooter] Footer background is not clipped to the popover panel border radius

3 participants