Skip to content

[EuiSplitButton] Update disabled style - #9986

Merged
mgadewoll merged 7 commits into
elastic:mainfrom
mgadewoll:splitbutton/update-disabled-styles
Sep 3, 2026
Merged

[EuiSplitButton] Update disabled style#9986
mgadewoll merged 7 commits into
elastic:mainfrom
mgadewoll:splitbutton/update-disabled-styles

Conversation

@mgadewoll

@mgadewoll mgadewoll commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • What: Updates EuiSplitButton disabled styles, inverting the container behavior.
  • Why: This is a follow-up to the previous redesign PR for EuiSplitButton to invert the disabled style when only a single action is disabled.
  • How: Applies disabled styles on the container only if both actions are disabled and not only a single one.

API Changes

⚪ No API changes

Screenshots

Description Before After
Light Screenshot 2026-09-02 at 09 18 21 Screenshot 2026-09-02 at 09 40 00
Dark Screenshot 2026-09-02 at 09 18 25 Screenshot 2026-09-02 at 09 40 13
Light HCM Screenshot 2026-09-02 at 09 19 07 Screenshot 2026-09-02 at 09 46 45
Dark HCM Screenshot 2026-09-02 at 09 19 12 Screenshot 2026-09-02 at 09 46 50

Impact Assessment

Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.

  • 🔴 Breaking changes — What will break? How many usages in Kibana/Cloud UI are impacted?
  • 💅 Visual changes — May impact style overrides; could require visual testing. Explain and estimate impact.
  • 🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).
  • 🔧 Hard to integrate — If changes require substantial updates to Kibana, please stage the changes and link them here.

Impact level: 🟢 Low

🧪 The changes have been run in Kibana CI (🟢 build)
Required Kibana changes: commits added here.

Release Readiness

  • Documentation: {link to docs page(s)}
  • Figma: {link to Figma or issue}
  • Migration guide: {steps or link, for breaking/visual changes or deprecations}
  • Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}

QA instructions for reviewer

  • verify style changes match design expectations (design review)
  • verify there are no unexpected regressions

Checklist before marking Ready for Review

Reviewer checklist

  • Approved Impact Assessment — Acceptable to merge given the consumer impact.
  • Approved Release Readiness — Docs, Figma, and migration info are sufficient to ship.

@mgadewoll mgadewoll self-assigned this Sep 2, 2026
@mgadewoll
mgadewoll requested a review from JoseLuisGJ September 2, 2026 07:43
@mgadewoll
mgadewoll force-pushed the splitbutton/update-disabled-styles branch from c3b26c0 to c009241 Compare September 2, 2026 07:47
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

📷 8 visual difference(s) found

Look at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes.

See the visual regression testing wiki for more information.

Expand to review

euisplitbutton (8 differences)

StoryDiff %BeforeAfterDiff
dark mode desktop 1.91%
high contrast mode dark desktop 1.96%
high contrast mode desktop 1.95%
kitchen sink desktop 1.90%
dark mode mobile 3.12%
high contrast mode dark mobile 3.21%
high contrast mode mobile 3.20%
kitchen sink mobile 3.12%

@mgadewoll

Copy link
Copy Markdown
Contributor Author

buildkite test this

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes align with the stated styling goal and the remaining feedback is limited to minor clarity/simplification opportunities.

Pull request overview

Updates EuiSplitButton styling so the container-level disabled presentation only applies when both split actions are disabled, aligning with the intended “single disabled action should not disable the whole control” behavior.

Changes:

  • Added a combined :has() selector to target the “both actions disabled” state and applied container disabled background only in that state.
  • Updated border/high-contrast styling logic to key off the “both disabled” condition (instead of “either disabled”).
  • Added an upcoming changelog entry for the EuiSplitButton disabled style update.
File summaries
File Description
packages/eui/src/components/button/split_button/split_button.styles.ts Adjusts disabled-state selectors so container/divider styling only switches to disabled when both actions are disabled.
packages/eui/changelogs/upcoming/9986.md Documents the EuiSplitButton disabled style update in the upcoming changelog.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/eui/src/components/button/split_button/split_button.styles.ts Outdated
Comment thread packages/eui/src/components/button/split_button/split_button.styles.ts Outdated
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

📷 8 visual difference(s) found

Look at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes.

See the visual regression testing wiki for more information.

Expand to review

euisplitbutton (8 differences)

StoryDiff %BeforeAfterDiff
dark mode desktop 1.91%
high contrast mode dark desktop 1.96%
high contrast mode desktop 1.95%
kitchen sink desktop 1.90%
dark mode mobile 3.12%
high contrast mode dark mobile 3.21%
high contrast mode mobile 3.20%
kitchen sink mobile 3.12%

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

📷 8 visual difference(s) found

Look at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes.

See the visual regression testing wiki for more information.

Expand to review

euisplitbutton (8 differences)

StoryDiff %BeforeAfterDiff
dark mode desktop 1.91%
high contrast mode dark desktop 1.96%
high contrast mode desktop 1.95%
kitchen sink desktop 1.90%
dark mode mobile 3.12%
high contrast mode dark mobile 3.21%
high contrast mode mobile 3.20%
kitchen sink mobile 3.12%

@mgadewoll

Copy link
Copy Markdown
Contributor Author

buildkite test this

@mgadewoll
mgadewoll marked this pull request as ready for review September 2, 2026 10:09
@mgadewoll
mgadewoll requested a review from a team as a code owner September 2, 2026 10:09

@weronikaolejniczak weronikaolejniczak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢 Thanks for the change, Lene!

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @mgadewoll

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @mgadewoll

@mgadewoll
mgadewoll merged commit 52274de into elastic:main Sep 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants