[EuiSplitButton] Update disabled style - #9986
Conversation
c3b26c0 to
c009241
Compare
📷 8 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. Expand to revieweuisplitbutton (8 differences)
|
|
buildkite test this |
There was a problem hiding this comment.
🟢 Approval recommended
The changes align with the stated styling goal and the remaining feedback is limited to minor clarity/simplification opportunities.
Pull request overview
Updates EuiSplitButton styling so the container-level disabled presentation only applies when both split actions are disabled, aligning with the intended “single disabled action should not disable the whole control” behavior.
Changes:
- Added a combined
:has()selector to target the “both actions disabled” state and applied container disabled background only in that state. - Updated border/high-contrast styling logic to key off the “both disabled” condition (instead of “either disabled”).
- Added an upcoming changelog entry for the
EuiSplitButtondisabled style update.
File summaries
| File | Description |
|---|---|
| packages/eui/src/components/button/split_button/split_button.styles.ts | Adjusts disabled-state selectors so container/divider styling only switches to disabled when both actions are disabled. |
| packages/eui/changelogs/upcoming/9986.md | Documents the EuiSplitButton disabled style update in the upcoming changelog. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📷 8 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. Expand to revieweuisplitbutton (8 differences)
|
📷 8 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. Expand to revieweuisplitbutton (8 differences)
|
|
buildkite test this |
weronikaolejniczak
left a comment
There was a problem hiding this comment.
LGTM 🟢 Thanks for the change, Lene!
💚 Build Succeeded
History
cc @mgadewoll |
💚 Build Succeeded
History
cc @mgadewoll |
























Summary
EuiSplitButtondisabled styles, inverting the container behavior.EuiSplitButtonto invert the disabled style when only a single action is disabled.API Changes
⚪ No API changes
Screenshots
Impact Assessment
Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.
Impact level: 🟢 Low
🧪 The changes have been run in Kibana CI (🟢 build)
Required Kibana changes: commits added here.
Release Readiness
QA instructions for reviewer
Checklist before marking Ready for Review
breaking changelabel (if applicable)Reviewer checklist