[Icon] New tableSparkles icon - #9987
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
There’s at least one concrete fix needed ('AI' synonym casing) and the PR also includes unrelated i18n token churn that should be confirmed intentional or split out.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new tableSparkles icon to EUI’s icon system (raw SVG + generated React asset) and registers it in the icon map so it can be used via <EuiIcon iconType="tableSparkles" />.
Changes:
- Added
table_sparkles.svgand the generatedassets/table_sparkles.tsxcomponent. - Registered
tableSparklesinicon_map.tswith search metadata synonyms. - Updated icon snapshots and added an upcoming changelog entry (plus additional i18n token file churn).
File summaries
| File | Description |
|---|---|
| packages/eui/src/components/icon/svgs/table_sparkles.svg | Adds the new raw SVG source for the icon. |
| packages/eui/src/components/icon/assets/table_sparkles.tsx | Adds the generated React icon component exported as icon. |
| packages/eui/src/components/icon/icon_map.ts | Registers tableSparkles and associates metadata/synonyms for search. |
| packages/eui/src/components/icon/snapshots/icon.test.tsx.snap | Updates Jest snapshots to include the new icon render output. |
| packages/eui/i18ntokens.json | Large i18n token file reordering/regeneration included in the PR. |
| packages/eui/i18ntokens_changelog.json | Adds a new i18n token changelog entry (version 120.0.0). |
| packages/eui/changelogs/upcoming/9987.md | Adds an upcoming changelog note for the new icon. |
Review details
- Files reviewed: 5/7 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
💔 Build Failed
Failed CI StepsHistory
cc @JoseLuisGJ |
💚 Build Succeeded
History
cc @JoseLuisGJ |
📷 2 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. |
weronikaolejniczak
left a comment
There was a problem hiding this comment.
LGTM! While you're here, @JoseLuisGJ, could you skip the mobile variant of the Icons story? We don't need it and it just slows down the CI. I ask because we need to update the snapshots.
Summary
tableSparklesicon.API Changes
<EuiIcon/>iconTypetableSparklesScreenshots
Impact Assessment
Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.
Impact level: 🟢 None / 🟢 Low / 🟡 Moderate / 🔴 High
Release Readiness
tableSparklescomponent already added into the Figma library hereQA instructions for reviewer
Checklist before marking Ready for Review
breaking changelabel (if applicable)Reviewer checklist