Skip to content

salesforce: use stream .request.host in system-test mock instance_url - #20522

Open
andrewkroh wants to merge 1 commit into
elastic:mainfrom
andrewkroh:fix/stream-request-host-salesforce
Open

salesforce: use stream .request.host in system-test mock instance_url#20522
andrewkroh wants to merge 1 commit into
elastic:mainfrom
andrewkroh:fix/stream-request-host-salesforce

Conversation

@andrewkroh

@andrewkroh andrewkroh commented Aug 4, 2026

Copy link
Copy Markdown
Member

Proposed commit message

Adopt stream {{ .request.host }} for the Salesforce system-test OAuth mock instance_url, bump the mock image to stream:v0.23.0, and remove the unused PORT compose env var (the server already listens via --addr=:8010).

This is a consistency/cleanup change: the mock should return the same origin the agent requested, using the new stream template field from elastic/stream#206 / elastic/stream#207, instead of reconstructing the URL from {{ hostname }} and PORT.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Confirm docker.elastic.co/observability/stream:v0.23.0 is published before merge
  • Run Salesforce system tests that use the mock instance_url

How to test this PR locally

elastic-package stack up -d --version 9.5.0-SNAPSHOT
cd packages/salesforce
elastic-package test system

Related issues

Screenshots

N/A — system-test mock and compose changes only.

@andrewkroh
andrewkroh requested a review from a team as a code owner August 4, 2026 15:22
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@andrewkroh
andrewkroh force-pushed the fix/stream-request-host-salesforce branch from 49d4924 to 38b88da Compare August 4, 2026 15:31
@andrewkroh andrewkroh added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] and removed Team:obs-infraobs-integrations labels Aug 4, 2026
Adopt {{ .request.host }} for the OAuth mock instance_url and bump the
mock image to stream v0.23.0 so the returned URL matches the host the
agent used. Drop the unused PORT env var (listen address is --addr=:8010).

Test-only changes; no package version or changelog updates.

Assisted-By: Cursor Grok 4.5
@andrewkroh andrewkroh changed the title salesforce: fix system-test mock origins with stream .request.host salesforce: use stream .request.host in system-test mock instance_url Aug 4, 2026
@andrewkroh
andrewkroh force-pushed the fix/stream-request-host-salesforce branch from 38b88da to 9e256de Compare August 4, 2026 15:38
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

@andrewkroh
andrewkroh marked this pull request as ready for review August 4, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:salesforce Salesforce Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant