[9.5] [ML] Make Appex QA/PyTorch tests version-aware on release branches#3116
Open
edsavage wants to merge 1 commit into
Open
[9.5] [ML] Make Appex QA/PyTorch tests version-aware on release branches#3116edsavage wants to merge 1 commit into
edsavage wants to merge 1 commit into
Conversation
The downstream appex-qa-stateful-custom-ml-cpp-build-testing pipeline
(elastic/qaf-tests) defaults to ES_BRANCH=main and STACK_VERSION=<current
main SNAPSHOT>, then downloads ml-cpp-<version>-SNAPSHOT-linux-x86_64.zip
from the parent build. On a release-branch / backport build the parent
produced ml-cpp-<release-version>-SNAPSHOT-... instead, so the download
missed ('No artifacts found') and the QA/PyTorch build failed spuriously
(e.g. a 9.5 backport looking for 9.6.0-SNAPSHOT).
Derive STACK_VERSION from gradle.properties (the exact artifact version)
and ES_BRANCH by comparing to ml-cpp main's version (main for the current
dev line, else major.minor), and forward both through the QA and PyTorch
downstream triggers. For main builds the derived values equal today's
defaults, so only release-branch/backport builds change behaviour. No
qaf-tests change is required; it already supports these overrides and lists
the active release branches/versions.
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
buildkite build |
|
Pinging @elastic/ml-core (Team:ML) |
Contributor
Author
|
buildkite run_pytorch_tests |
Contributor
Author
|
buildkite build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3115 to
9.5.Makes the Appex QA/PyTorch downstream trigger pass
STACK_VERSION/ES_BRANCHderived from this build (9.5.0 / 9.5) so the downstream finds theml-cpp-9.5.0-SNAPSHOTartifact instead of defaulting to main's9.6.0-SNAPSHOT.This PR also serves as the live end-to-end test:
ci:run-pytorch-testswill be applied so the 9.5 build exercises the downstream QA pytorch pipeline with the fix in place.Made with Cursor