Add TS typings #78 - #103
Open
Ricy137 wants to merge 3 commits into
Open
Conversation
Ricy137
marked this pull request as ready for review
July 8, 2024 08:12
SamWilsn
reviewed
Sep 3, 2024
SamWilsn
left a comment
SamWilsn
left a comment
Collaborator
There was a problem hiding this comment.
Sorry for the long wait! This is looking good; thank you so much.
| }, | ||
| "keywords": [], | ||
| "author": "", | ||
| "license": "ISC", |
Collaborator
There was a problem hiding this comment.
Should be MPL-2.0 to match the rest of the project.
|
|
||
| export type Date<S> = S; | ||
|
|
||
| export type DefaultLint<S> = |
Collaborator
There was a problem hiding this comment.
Can you think of a way we can get a compile or test failure if this list gets out of sync with DefaultLint?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #78