fix: send raw ArrayBuffer as binary instead of JSON - #7453
Closed
dajiaohuang wants to merge 1 commit into
Closed
Conversation
Fixes expressjs#7362 res.send(ArrayBuffer) was sending {} because ArrayBuffer.isView() returns false for raw ArrayBuffer, causing it to fall through to this.json(). This adds an instanceof ArrayBuffer check to handle raw ArrayBuffer like TypedArray views - setting Content-Type to 'bin' and converting to Buffer.
Contributor
|
Duplicate of #7363 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7362
res.send(ArrayBuffer) was sending {} with Content-Type: application/json because ArrayBuffer.isView() returns false for raw ArrayBuffer, causing it to fall through to this.json().
Problem
ArrayBuffer.isView()only returns true for TypedArray views (likeUint8Array), but rawArrayBufferis not a view, so it falls through tothis.json(chunk)producing{}.Solution
Add
instanceof ArrayBuffercheck to handle raw ArrayBuffer like TypedArray views:Verification