[hmdsefi]

Related Issues

Fixes #10697

Proposed Changes

• moveSelector.Ok first checks if the worker already has every requested file type in one of its paths of the destination type (CanStore for long-term storage), allowed by that path's type filters. If it does, the move is a no-op, and the worker is accepted and preferred without calling StorageBestAlloc.
• Add TestMoveSelectorFullStorage in sched_test.go. It covers a full long-term storage path that already has the sealed and cache files, and a move that also includes an unsealed file from the sealing path, which still fails with no good path found.
• CHANGELOG entry.

Additional Info

The selector called StorageBestAlloc for every move and returned its error. When the storage paths are full that is finding best dest storage: no good path found for every worker, so the scheduler logs trySched(1) req.Sel.Ok error on each pass and the fetch task never runs. FinalizeReplicaUpdate hits this for snap deals: it runs move(FTCache) and move(FTSealed), and those files are normally already in long-term storage. Once the update files are moved there, the path may not have a full sector of free space left, and the sector stays in FinalizeReplicaUpdate.

The move itself is already a no-op on master. Since e86d81b, Local.AcquireSector also looks for existing files when it's asked to allocate, and uses them if the path fits the request, so Local.MoveStorage finds the destination without needing free space. I checked this with a scratch test on a full path: MoveStorage returns nil, while StorageBestAlloc returns no good path found. After the move, LocalWorker.MoveStorage still removes copies left in sealing paths.

If any requested file still has to be moved, the selector works as before and needs free space for it.

This changes a different part of Ok than my PR for #9946 (DisallowRemoteFinalize). The two merge without conflicts in selector_move.go, and both tests pass on the merged code.

Tests:

• go test ./storage/sealer/ passes.
• With the selector_move.go change reverted, TestMoveSelectorFullStorage fails with finding best dest storage: no good path found.
• gofmt, go vet and golangci-lint v1.64.8 report no issues for ./storage/sealer/....

Checklist

Before you mark the PR ready for review, please make sure that:

• Commits have a clear commit message.
• PR title conforms with contribution conventions
• Update CHANGELOG.md or signal that this change does not need it per contribution conventions
• New features have usage guidelines and / or documentation updates in
  • Lotus Documentation
  • Discussion Tutorials
• Tests exist for new functionality or change in behavior
• CI is green