Skip to content

Reject unsupported Spark Name operations - #2

Merged
reubenyap merged 3 commits into
mainfrom
codex/firo-spark-name-format
Jul 23, 2026
Merged

reubenyap merged 3 commits into
mainfrom
codex/firo-spark-name-format

Conversation

@reubenyap

Copy link
Copy Markdown
Member

What changed

  • Rejects non-registration operation types in the vendored Spark Name serializer.
  • Adds serialization and deserialization regression coverage.

Why

The mobile layout is intentionally registration-only. Accepting operation type 1 would otherwise emit or partially decode a transfer payload without its required transfer fields.

Related

@codeant-ai

codeant-ai Bot commented Jul 23, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 8f4e016 Jul 23, 2026 · 13:14 13:18

Updated in place by CodeAnt AI · last 5 reviews

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Jul 23, 2026
@codeant-ai

codeant-ai Bot commented Jul 23, 2026

Copy link
Copy Markdown

User description

What changed

  • Rejects non-registration operation types in the vendored Spark Name serializer.
  • Adds serialization and deserialization regression coverage.

Why

The mobile layout is intentionally registration-only. Accepting operation type 1 would otherwise emit or partially decode a transfer payload without its required transfer fields.

Related


CodeAnt-AI Description

Reject unsupported Spark Name operation types

What Changed

  • Spark Name data now rejects operation types other than registration when saving or reading a v2 payload.
  • Added regression tests that cover unsupported versions and unsupported operation types in both directions.

Impact

✅ Fewer invalid Spark Name payloads
✅ Clearer errors when opening unsupported names
✅ Safer Spark Name import and export

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f4e01610c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/deps/sparkmobile/tests/spark_name_test.cpp Outdated
@reubenyap
reubenyap merged commit 90f1f64 into main Jul 23, 2026
@reubenyap
reubenyap deleted the codex/firo-spark-name-format branch July 23, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant