Change styling of position readout - #729
Conversation
📝 WalkthroughWalkthroughThe position readout now renders grouped segments with axis color bars instead of bordered pills. Gizmo status entries explicitly use the ChangesPosition readout
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/gizmos.test.js (1)
258-270: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winExercise the actual gizmo-switch path.
This test calls
exitGizmoState()directly, so it does not prove that selecting a different gizmo clears the readout. Switch between two gizmos through the public selection path and assert the position-owned status is cleared.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/gizmos.test.js` around lines 258 - 270, Update the test around exitGizmoState to exercise the public gizmo-selection path: select one gizmo, set the position-owned status, then select a different gizmo and assert the status text is cleared. Do not call exitGizmoState directly; use the existing public gizmo selection symbol and preserve the cleanup logic.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/gizmos.test.js`:
- Around line 258-270: Update the test around exitGizmoState to exercise the
public gizmo-selection path: select one gizmo, set the position-owned status,
then select a different gizmo and assert the status text is cleared. Do not call
exitGizmoState directly; use the existing public gizmo selection symbol and
preserve the cleanup logic.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 20ab1cbe-8afb-4057-909c-b99aba2b7e44
📒 Files selected for processing (5)
style.csstests/gizmos.test.jstests/status.test.jsui/gizmos.jsui/status.js
Summary
Change the styling of the position readout so that it does not appear editable when it isn't
AI usage
Claude Opus 5 used. Styling decided by me.
Summary by CodeRabbit
Style
Bug Fixes