Skip to content

Skip events on invalid state, increase grpc max size #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fkenji wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Skip events on invalid state, increase grpc max size #143

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3bbfaca
Add more logs
fkenji Dec 3, 2021
c18760c
Fix typo
fkenji Dec 3, 2021
0a2a08e
Log info
fkenji Dec 4, 2021
47325ed
Ignore state error for now
fkenji Dec 4, 2021
d288bdc
Log pack info
fkenji Dec 4, 2021
ae1b438
FIx log format
fkenji Dec 4, 2021
27a277b
Continue on wrong state
fkenji Dec 4, 2021
2c5c7db
Undo logging changes
fkenji Dec 7, 2021
c352d9b
Fix log
fkenji Dec 8, 2021
b4142eb
Just log for now
fkenji Dec 8, 2021
e0500ca
Just log for now
fkenji Dec 8, 2021
71f3b35
Skip on errors
fkenji Dec 8, 2021
be41ef3
Add more logs
fkenji Dec 9, 2021
c89a6cd
Add more logs
fkenji Dec 9, 2021
5707e04
Add skip
fkenji Dec 9, 2021
f25e9c3
Increase default size for every call
fkenji Dec 17, 2021
a14e2bc
split poller
judezhu Jan 6, 2022
d8242d7
Merge pull request #2 from judezhu/judez/added-more-pollers
fkenji Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,10 @@ func runServer(cfg *config.Config) error {

// Flow client
// TODO: WithInsecure()?
flowClient, err := client.New(cfg.AccessAPIHost, grpc.WithInsecure())
maxSize := 1024 * 1024 * 64
flowClient, err := client.New(cfg.AccessAPIHost, grpc.WithInsecure(),
grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(maxSize)),
)
if err != nil {
return err
}
Expand Down
17 changes: 12 additions & 5 deletions service/app/contract_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,8 @@ func (svc *ContractService) UpdateMintingStatus(ctx context.Context, db *gorm.DB
// Set the FlowID of the pack
// Make sure the pack is in correct state
if err := pack.Seal(packFlowID); err != nil {
return err // rollback
logger.Warn(fmt.Sprintf("pack in wrong state %s packFlowId:%+v", err, packFlowID))
continue
}

// Update the pack in database
Expand Down Expand Up @@ -910,14 +911,17 @@ func (svc *ContractService) UpdateCirculatingPackContract(ctx context.Context, d
"packFlowID": pack.FlowID,
})

eventLogger.Info("handling event...")

switch eventName {
// -- REVEAL_REQUEST, Owner has requested to reveal a pack ------------
case REVEAL_REQUEST:

// Make sure the pack is in correct state
if err := pack.RevealRequestHandled(); err != nil {
err := fmt.Errorf("error while handling %s: %w", eventName, err)
return err // rollback
eventLogger.Warn(fmt.Sprintf("distID:%s distFlowID:%s packID:%s packFlowID:%s err:%s", distribution.ID, distribution.FlowID, pack.ID, pack.FlowID, err.Error()))
continue
}

// Update the pack in database
Expand Down Expand Up @@ -1006,7 +1010,8 @@ func (svc *ContractService) UpdateCirculatingPackContract(ctx context.Context, d
// Make sure the pack is in correct state
if err := pack.Reveal(); err != nil {
err := fmt.Errorf("error while handling %s: %w", eventName, err)
return err // rollback
eventLogger.Warn(fmt.Sprintf("distID:%s distFlowID:%s packID:%s packFlowID:%s err:%s", distribution.ID, distribution.FlowID, pack.ID, pack.FlowID, err.Error()))
continue
}

// Update the pack in database
Expand All @@ -1020,7 +1025,8 @@ func (svc *ContractService) UpdateCirculatingPackContract(ctx context.Context, d
// Make sure the pack is in correct state
if err := pack.OpenRequestHandled(); err != nil {
err := fmt.Errorf("error while handling %s: %w", eventName, err)
return err // rollback
eventLogger.Warn(fmt.Sprintf("distID:%s distFlowID:%s packID:%s packFlowID:%s err:%s", distribution.ID, distribution.FlowID, pack.ID, pack.FlowID, err.Error()))
continue
}

// Update the pack in database
Expand Down Expand Up @@ -1088,7 +1094,8 @@ func (svc *ContractService) UpdateCirculatingPackContract(ctx context.Context, d
// Make sure the pack is in correct state
if err := pack.Open(); err != nil {
err := fmt.Errorf("error while handling %s: %w", eventName, err)
return err // rollback
eventLogger.Warn(fmt.Sprintf("distID:%s distFlowID:%s packID:%s packFlowID:%s err:%s", distribution.ID, distribution.FlowID, pack.ID, pack.FlowID, err.Error()))
continue
}

// Update the pack in database
Expand Down