Upgrade to Go 1.27 - #7949
Open
Sovietaced wants to merge 2 commits into
Open
Upgrade to Go 1.27#7949Sovietaced wants to merge 2 commits into
Sovietaced wants to merge 2 commits into
Conversation
Sovietaced
force-pushed
the
go-1.27
branch
2 times, most recently
from
September 2, 2026 19:20
40b098b to
f023bae
Compare
Sovietaced
commented
Sep 2, 2026
| ) | ||
|
|
||
| func TestAzureTemplateLogPlugin(t *testing.T) { | ||
| type args struct { |
Member
Author
There was a problem hiding this comment.
Go 1.27 changed the compress/flate implementation, so gzip output can produce different—but equally valid—compressed bytes.
The Azure test previously asserted the entire generated URL, including a hard-coded base64-encoded gzip payload. After upgrading Go, that byte-for-byte value changed even though the decompressed Azure query was identical.
I changed this to verify the meaningful behavior:
- Check the Azure URL prefix and log metadata.
- URL-decode the query.
- Base64-decode it.
- Gzip-decompress it.
- Compare the resulting query text with the expected query.
So it was a test-stability adjustment required by Go 1.27’s compression change, not a production behavior change. It also avoids future failures when compression output changes without changing its contents.
Sovietaced
marked this pull request as ready for review
September 2, 2026 19:43
Sovietaced
force-pushed
the
go-1.27
branch
2 times, most recently
from
September 15, 2026 07:06
69868d4 to
af71fed
Compare
popojk
reviewed
Sep 16, 2026
popojk
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution. I just left 2 small comments.
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
New versions of Go include new features, performance improvements, and security fixes. See: https://go.dev/doc/go1.27
What changes were proposed in this pull request?
Leveraged Go 1.27 to do the following
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link