Repository navigation
fix: handle interlaced PNG with indexed transparency - #1673
Merged
Merged
Conversation
issue foliojs#414 snapshot shows corrupted rendering due to bug in interlaced PNG handling. This will be fixed in the next commit.
For interlaced PNG images with indexed transparency (tRNS chunk), the decoded pixel data was not being re-encoded after deinterlacing. This caused corrupted rendering as the original interlaced data was used instead. The fix re-encodes the deinterlaced pixel data when processing interlaced images in loadIndexedAlphaChannel().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The 1st commit 99a0300 shows the broken rendering, which is fixed by the 2nd commit
Checklist: