chore: pending worktree changes (prtriage ignore, Igra vector mark, send validation copy) - #338
Conversation
The network icon embedded a 200x200 PNG of the gold wordmark inside a 17.8 KB SVG. It is now the arrow mark as vector paths in the same 65x64 black disc, 1.3 KB. Used only by lib/layer2.ts; the Names cards use the separate igra-lockup.png and are unaffected.
…n error Both send forms resolve only .kas names (KNS). "Invalid address or KNS domain" now reads "Invalid Kaspa address or .kas domain".
|
Note
|
| Layer / File(s) | Summary |
|---|---|
Kaspa address validation text components/send/kas-send/DetailsStep.tsx, components/send/krc20-send/DetailsStep.tsx |
Validation errors now reference Kaspa addresses and .kas domains. |
Workspace cleanup
| Layer / File(s) | Summary |
|---|---|
Ignore untracked scratch mirror .gitignore |
The prtriage/ directory is documented and ignored. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Merge Risk: ⚪ Minimal · up to c445b
This updates recipient-validation wording, ignores a local scratch directory, and replaces a logo asset with a smaller vector version. The send flows retain existing validation behavior, with no current merge-readiness risk identified.
Suggested reviewers: dadamu
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title identifies all three changes: the prtriage ignore rule, the Igra vector mark, and the send validation copy update. It is specific and related to the pull request. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
chore/pending-worktree
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
🟡 Changes recommended
The new .gitignore comment is factually misleading about tsc behavior and should be reworded for accuracy.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR batches three small housekeeping changes: ignoring a local scratch directory, updating the IGRA network logo asset to a true vector SVG, and refining the recipient validation error copy in the Kaspa/KRC20 send flows.
Changes:
- Add
prtriage/to.gitignoreto keep a large untracked mirror out ofgit status/ accidental adds. - Replace
assets/images/network-logos/igra.svgembedded-PNG SVG with a lightweight vector mark. - Update send-form validation copy to: “Invalid Kaspa address or .kas domain”.
File summaries
| File | Description |
|---|---|
.gitignore |
Ignores prtriage/ scratch directory (comment text needs a small correction). |
assets/images/network-logos/igra.svg |
Swaps embedded raster for vector polygons for the IGRA icon. |
components/send/kas-send/DetailsStep.tsx |
Updates recipient validation error copy for Kaspa sends. |
components/send/krc20-send/DetailsStep.tsx |
Updates recipient validation error copy for KRC20 sends. |
Review details
- Files reviewed: 2/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Three unrelated working-tree changes that predate v2.60.0 and were kept out of every PR so far, each re-verified against current main (7e10fd2) before committing. One commit each.
.gitignore— ignoreprtriage/prtriage/is an untracked scratch mirror of tracked sources (~45k files). Ignoring it keeps it out ofgit statusand out of accidentalgit add -A. Note: this does not affecttsc, which still walks the directory (8 pre-existing errors there); that would need atsconfigexclude, not done here.assets/images/network-logos/igra.svg— vector mark instead of embedded rastermain: 17,850 B SVG whose only content is a 200×200 PNG of the gold "igra" wordmark, embedded as a pattern fill. This branch: the arrow mark as vector polygons inside the same 65×64 black disc, 1,329 B.
Still wanted: the only consumer is
lib/layer2.ts(network icon). The v2.60.0 Names redesign vendoredigra-lockup.pngforNameCard.tsxseparately, so this file is not superseded. Both variants were rendered to PNG and compared; both draw the same black disc at 64×64, one with the wordmark, one with the mark.components/send/{kas-send,krc20-send}/DetailsStep.tsx— validation copy"Invalid address or KNS domain"→"Invalid Kaspa address or .kas domain". Still accurate: both validators resolve onlyvalue.endsWith(".kas")viauseKns;.igranames are handled in the transfer flows, not here.Left alone, flagged for a follow-up:
KNSTransferDetails.tsx:80still uses the old string, and both inputs' placeholder is still"Enter wallet address or KNS".No source on other branches touched. Not a money path.
🤖 Generated with Claude Code
Summary by CodeRabbit
.kasdomains in Kaspa and KRC-20 send flows.