Repository navigation
Ensure dropbox app sync works with whitespaces - #207
Merged
Merged
Conversation
Dropbox removed the whitespace from their JSON response. Since the regular expression matchers included those spaces, they did not work anymore. Made these spaces optional to ensure it works both with and without spaces. Additionally, it seems that they sorted their response attributes. This resulted in the `size` attribute being last and therefore there is no attribute after size and thus the match on the comma separator did not work. To make it even more future proof, proper JSON parsing would be nice but that is a big change. This is a "quick fix" that works and is easy to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropbox removed the whitespace from their JSON response. Since the regular expression matchers included those spaces, they did not work anymore. Made these spaces optional to ensure it works both with and without spaces.
Additionally, it seems that they sorted their response attributes. This resulted in the
sizeattribute being last and therefore there is no attribute after size and thus the match on the comma separator did not work.To make it even more future proof, proper JSON parsing would be nice but that is a big change. This is a "quick fix" that works and is easy to understand.