adapt for MeshSequence - #287
Conversation
|
@sghelichkhani Is the CI failure my fault, or is it a common issue? |
|
Hi @ksagiyam, not your fault. It happened as a stage in the CI requires secrets access to download a file from an s3 bucket, which forks are not allowed to access. We'll put in an update that addresses this. |
56aa934 to
ba74c82
Compare
dsroberts
left a comment
dsroberts
left a comment
There was a problem hiding this comment.
Thanks for your contribution @ksagiyam. We've been working around this on your submesh_core branch for a while now, so its good to have an 'official' fix. That being said, what you have doesn't quite fit with our (unwritten, unofficial) style preferences, specifically, the import in a place other than the top of a file. All we need is the try/except block moved to the top with the rest of the imports and is_cartesian modified accordingly.
ba74c82 to
0ee3210
Compare
7339ea5 to
5c6f181
Compare
5c6f181 to
48191f8
Compare
Required for firedrakeproject/firedrake#3478, but can be merged independently. --------- Co-authored-by: Dale Roberts <dale.roberts1@anu.edu.au>
2 participants
Required for firedrakeproject/firedrake#3478, but can be merged independently.