fix(with-react-native): bump the socket.io-parser pin to 4.2.7 - #132
Merged
Conversation
The override pinned exactly 4.2.6 to remediate the earlier <4.2.6 advisory. GHSA-2m8v-j782-fhvr (zero-attachment memory exhaustion, high) now covers <4.2.7, so that pin holds the example on a known-vulnerable version, reached through @metamask/sdk's socket.io-client. CI does not catch it because this example audits at critical rather than high, so the dependency is genuinely vulnerable while the build stays green. Bumps the existing pin rather than adding a second override: a `<4.2.7` override alongside `<4.2.6: 4.2.6` loses to the more specific pin and silently does nothing. Same fix as with-reown in #131. Verified: --frozen-lockfile passes, socket.io-parser resolves to 4.2.7 and no longer appears in the audit, and the lockfile diff touches nothing else. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Dependency limit exceeded — report not shown. This pull request scan exceeded the 10,000-dependency limit applied to this scan, so the results are incomplete and may be inaccurate. To avoid reporting false positives, Socket has not posted a report. Upgrade your plan to raise the dependency limit and get complete reports, or view the partial scan in the dashboard. Socket is always free for open source. If this is a non-commercial open source project, contact us to request a free Team account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #131, which fixed the same issue in
with-reown.The problem
with-react-native's override pinssocket.io-parserto exactly4.2.6, which remediated the earlier<4.2.6advisory. GHSA-2m8v-j782-fhvr (zero-attachment memory exhaustion, high) now covers<4.2.7, so that pin actively holds the example on a known-vulnerable version. It is reached through@metamask/sdk'ssocket.io-client.CI does not catch this: the matrix audits
with-react-nativeatcritical, nothigh, so the build stays green while the dependency is genuinely vulnerable.Why bump the pin rather than add an override
Adding
socket.io-parser@<4.2.7: ^4.2.7alongside the existing<4.2.6: 4.2.6silently does nothing — it registers in the lockfile, the more specific pin still wins, and resolution stays at 4.2.6. I hit exactly that while fixingwith-reown. The existing pin has to be bumped.Verification
pnpm install --frozen-lockfilepassessocket.io-parserresolves to4.2.7and no longer appears inpnpm auditat allcritical(CI's level for this example)socket.io-parser, nothing else re-resolvedTwo unrelated
highadvisories remain (fast-uri,shell-quote). Both predate this change and are outside its scope; neither affects CI atcritical.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.