Skip to content

fix(with-react-native): bump the socket.io-parser pin to 4.2.7 - #132

Merged
yosriady merged 1 commit into
mainfrom
fix/rn-socket-io-parser-advisory
Aug 5, 2026
Merged

fix(with-react-native): bump the socket.io-parser pin to 4.2.7#132
yosriady merged 1 commit into
mainfrom
fix/rn-socket-io-parser-advisory

Conversation

@yosriady

@yosriady yosriady commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #131, which fixed the same issue in with-reown.

The problem

with-react-native's override pins socket.io-parser to exactly 4.2.6, which remediated the earlier <4.2.6 advisory. GHSA-2m8v-j782-fhvr (zero-attachment memory exhaustion, high) now covers <4.2.7, so that pin actively holds the example on a known-vulnerable version. It is reached through @metamask/sdk's socket.io-client.

CI does not catch this: the matrix audits with-react-native at critical, not high, so the build stays green while the dependency is genuinely vulnerable.

socket.io-parser@<4.2.6: 4.2.6   # before
socket.io-parser@<4.2.7: 4.2.7   # after

Why bump the pin rather than add an override

Adding socket.io-parser@<4.2.7: ^4.2.7 alongside the existing <4.2.6: 4.2.6 silently does nothing — it registers in the lockfile, the more specific pin still wins, and resolution stays at 4.2.6. I hit exactly that while fixing with-reown. The existing pin has to be bumped.

Verification

  • pnpm install --frozen-lockfile passes
  • socket.io-parser resolves to 4.2.7 and no longer appears in pnpm audit at all
  • audit passes at critical (CI's level for this example)
  • the lockfile diff touches only socket.io-parser, nothing else re-resolved

Two unrelated high advisories remain (fast-uri, shell-quote). Both predate this change and are outside its scope; neither affects CI at critical.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Review in cubic

The override pinned exactly 4.2.6 to remediate the earlier <4.2.6 advisory.
GHSA-2m8v-j782-fhvr (zero-attachment memory exhaustion, high) now covers
<4.2.7, so that pin holds the example on a known-vulnerable version, reached
through @metamask/sdk's socket.io-client.

CI does not catch it because this example audits at critical rather than
high, so the dependency is genuinely vulnerable while the build stays green.

Bumps the existing pin rather than adding a second override: a `<4.2.7`
override alongside `<4.2.6: 4.2.6` loses to the more specific pin and
silently does nothing. Same fix as with-reown in #131.

Verified: --frozen-lockfile passes, socket.io-parser resolves to 4.2.7 and no
longer appears in the audit, and the lockfile diff touches nothing else.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@socket-security

Copy link
Copy Markdown

Dependency limit exceeded — report not shown.

This pull request scan exceeded the 10,000-dependency limit applied to this scan, so the results are incomplete and may be inaccurate. To avoid reporting false positives, Socket has not posted a report.

Upgrade your plan to raise the dependency limit and get complete reports, or view the partial scan in the dashboard.

Socket is always free for open source. If this is a non-commercial open source project, contact us to request a free Team account.

@yosriady
yosriady merged commit 28b5f3a into main Aug 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant