Update React Native example to @formo/analytics-react-native 1.1.0 - #134
Merged
Conversation
Picks up getformo/sdk-react-native#83: traffic-source sanitization for values captured from deep links and the Android install referrer, immediate delivery of the first event of an app session, and a batch of queue and teardown reliability fixes. No app code changes are needed — 1.1.0 has no API, type or export changes. Verified against the published package end to end, with the example running under Metro and events pointed at a local collector: - a clean marketing link keeps all six utm_*/ref values, no false positives, and events report library_version 1.1.0 - the first batch on the wire carries exactly one event, so cold-start attribution is not held for the batch timer - double-encoded, scheme-in-value, multi-byte and raw-markup payloads in a deep link are all dropped, while clean values alongside them survive - UI-driven events batch rather than sending one request per interaction - against a collector rejecting every request, batches are dropped once rather than re-posted forever, and no unhandled rejection reaches the app - three unmount -> cleanup -> re-init cycles each re-initialize and deliver `pnpm install --frozen-lockfile`, `pnpm typecheck` and the example's tests all pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Dependency limit exceeded — report not shown. This pull request scan exceeded the 10,000-dependency limit applied to this scan, so the results are incomplete and may be inaccurate. To avoid reporting false positives, Socket has not posted a report. Upgrade your plan to raise the dependency limit and get complete reports, or view the partial scan in the dashboard. Socket is always free for open source. If this is a non-commercial open source project, contact us to request a free Team account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the React Native example from
^1.0.2to^1.1.0, picking up sdk-react-native#83.package.json+pnpm-lock.yamlonly — no app code changes are needed, since 1.1.0 has no API, type, export or dependency changes.What the example gains
utm_*/ref/referrercaptured from deep links and the Android Play install referrer were previously stored and replayed onto every event with no validation.flushAtor the 30s timer — exactly the events lost to a force-quit or OS memory kill.Verification
Ran against the published package, with the example under Metro and events pointed at a local collector so the exact wire payloads could be asserted on rather than inferred:
utm_*/refvalues intact — no false positiveslibrary_versionon the wire1.1.0utm_medium/utm_contentalongside them survived;referrerdroppedUncaught (in promise)in a clean consolepnpm install --frozen-lockfile,pnpm typecheckand the example's 14 tests all pass.Notes for the reviewer
apiHostoverride used to point events at the local collector was test-only and is not in this diff — the change is strictly the two dependency files.pnpm lintfails in this example on a missing ESLint config. That is pre-existing (it fails identically on unmodifiedmain) and CI runstypecheckforwith-react-native, not lint — so it is out of scope here.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.