Skip to content

feat(ariadne): Gate GraphQL data collection behind data_collection option#6890

Draft
ericapisani wants to merge 1 commit into
py-2585-gqlfrom
py-2585-ariadne
Draft

feat(ariadne): Gate GraphQL data collection behind data_collection option#6890
ericapisani wants to merge 1 commit into
py-2585-gqlfrom
py-2585-ariadne

Conversation

@ericapisani

@ericapisani ericapisani commented Jul 24, 2026

Copy link
Copy Markdown
Member

Filter the GraphQL document and variables attached to error events based on the structured data_collection configuration (graphql.document / graphql.variables), falling back to send_default_pii when data_collection is not set. The document remains subject to max_request_body_size; variables are not. When both are disabled, any request data attached by other integrations is scrubbed. Response body capture remains tied to send_default_pii.

Refs PY-2585
Refs #6745

…tion

Filter the GraphQL document and variables attached to error events based on the structured data_collection configuration (graphql.document / graphql.variables), falling back to send_default_pii when data_collection is not set. The document remains subject to max_request_body_size; variables are not. When both are disabled, any request data attached by other integrations is scrubbed. Response body capture remains tied to send_default_pii.
@ericapisani
ericapisani requested a review from a team as a code owner July 24, 2026 20:04
@linear-code

linear-code Bot commented Jul 24, 2026

Copy link
Copy Markdown

PY-2585

@ericapisani
ericapisani marked this pull request as draft July 24, 2026 20:06
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

97977 passed | ⏭️ 6410 skipped | Total: 104387 | Pass Rate: 93.86% | Execution Time: 349m 7s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +545
Passed Tests 📈 +546
Failed Tests 📉 -1
Skipped Tests

➖ Removed Tests (1)

View removed tests
  • test_circular_references_span_streaming
    • File: tests.tracing.test_misc

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2512 uncovered lines.
✅ Project coverage is 89.73%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.71%    89.73%    +0.02%
==========================================
  Files          193       193         —
  Lines        24392     24448       +56
  Branches      8642      8690       +48
==========================================
+ Hits         21882     21936       +54
- Misses        2510      2512        +2
- Partials      1399      1403        +4

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant