fix(notifications): mark subscription tools destructive#2936
Open
SamMorrowDrums wants to merge 1 commit into
Open
fix(notifications): mark subscription tools destructive#2936SamMorrowDrums wants to merge 1 commit into
SamMorrowDrums wants to merge 1 commit into
Conversation
Both tools expose a delete action, so the tool-level annotation must remain conservative even though their other actions only update preferences. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: be9c15fe-a113-4ebd-b9ab-09a520d522b6
Contributor
There was a problem hiding this comment.
Pull request overview
Explicitly marks notification subscription tools as destructive because both support deletion.
Changes:
- Sets
DestructiveHinttotruefor both tools. - Adds unit assertions and updates tool snapshots.
Show a summary per file
| File | Description |
|---|---|
pkg/github/notifications.go |
Adds explicit destructive annotations. |
pkg/github/notifications_test.go |
Verifies annotations are present and true. |
pkg/github/__toolsnaps__/manage_notification_subscription.snap |
Updates emitted schema snapshot. |
pkg/github/__toolsnaps__/manage_repository_notification_subscription.snap |
Updates emitted schema snapshot. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
The MCP
2026-07-28draft definesdestructiveHint: falseto mean that a tool performs only additive updates. Both tools expose adeleteaction that removes a subscription, and annotations apply to the whole tool rather than individual action values. They therefore need to advertisedestructiveHint: true.The protocol default remains
true, so this does not change effective behavior. It makes the behavior conscious and explicit undermodelcontextprotocol/go-sdkv1.7.0-pre.3, which represents this default-true field as an optional pointer.Specification: https://modelcontextprotocol.io/specification/draft/schema#toolannotations
This supersedes #2845 and #2884, which set the hint to
false.Closes #2841