fix(swift): scope JSON helpers to standalone output - #3094
Open
foobra wants to merge 2 commits into
Open
Conversation
Generated-output differences314 files differ — 314 modified, 0 new, 0 deleted |
Generated-output differences314 files differ — 314 modified, 0 new, 0 deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3093
Swift standalone output can contain duplicate module-level
newJSONDecoderandnewJSONEncoderdeclarations when several generated files are compiled together. The original single-file fix usedfileprivate, but the helpers were later moved toJSONSchemaSupport.swiftfor multi-file output and changed back to internal visibility.This makes the visibility conditional:
fileprivate--multi-file-output: internal visibility inJSONSchemaSupport.swiftAdded regression coverage for both rendering modes. Verified the unit tests, build, and Swift type-checking for generated standalone and multi-file output.