Make MDL SVG rendering deterministic - #1130
Merged
Merged
Conversation
Wait for mounted graphs and browser completion, keep labels clear of diagram elements, and honor each view's layout direction unless explicitly overridden.
Give CI the same browser startup budget as the SVG regression tests so the synthetic error contract is measured after Chrome is ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mdl svgcould start saving before the lazy graph mounted, then hide the browser error and time out while polling for a file. Automatic relationship labels could overlap nodes, and the CLI's implicitDOWNdirection overrode each view'sAutoLayoutdeclaration.Outcome
-direction DOWN|UP|LEFT|RIGHTremains an explicit override; invalid values now fail instead of silently falling back.The browser owns graph readiness and action sequencing, the save endpoint owns durable file creation, and the CLI owns timeout and diagnostic reporting. No model membership, relationship selection, or authored manual layout contract changes.
Compatibility
Callers that unintentionally relied on the old implicit top-to-bottom override will now receive their view's declared direction. They can preserve the old output with
-direction DOWN.Validation
pnpm exec tsc --noEmitpnpm run buildCHROME_BIN=\"/Applications/Google Chrome.app/Contents/MacOS/Google Chrome\" go test ./... -count=1Review guide
Start with the automation status contract in
Root.tsxandmain.go, then review collision scoring ingraph.tsand view-direction mapping inparseModel.ts. Browser-backed regressions are insvg_e2e_test.go.