feat(wish): the door reads the tender's heartbeat before planting - #75
Merged
Merged
Conversation
The assignment plant refuses loudly when the named sender's state row is stale or the tender is unknown. Flight 9 stamped 'assigned' while writing into a torn-down cell's db — the note vanished, nobody adopted, and the failure surfaced only as archaeology. Now: dead address, loud refusal on the wish, with the reason. The stale window derives from the tender's DECLARED cadence (the beater writes its interval into the row): alive iff age <= 3 x interval, falling back to a fixed 300s only before the second beat. The heartbeat age is computed by the tender's own archive db clock and read over the same connection the delivery uses. Registry stays the existence check; the heartbeat is the breath. Tests: TestSenderLivenessAtTheDoor (6), unit suite 158 passed. Co-authored-by: cherusk <10729954+cherusk@users.noreply.github.com>
godon-robot
Bot
force-pushed
the
feat/wish-door-liveness
branch
from
September 23, 2026 07:36
b056ec0 to
2006548
Compare
read_heartbeat falls back to an age-only read when the state row predates the interval column (rollout-order independent); the fallback birth window tightens 300s -> 60s (it only serves a tender's first seconds, before its second beat reports the interval). Tests: age-only fallback + cadence-derived window + fallback window. Co-authored-by: cherusk <10729954+cherusk@users.noreply.github.com>
The previous commit accidentally excluded the test-file edits: the fallback-window values (59/61 against the 60s birth fallback) and the age-only-fallback test for pre-column state rows. Co-authored-by: cherusk <10729954+cherusk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The door reads the tender's heartbeat before planting.
The assignment plant refuses loudly when the named sender's state row is stale (no beat within GODON_HEARTBEAT_TTL_SECS, default 300s) or the tender is unknown. Flight 9 stamped 'assigned' while writing into a torn-down cell's db — the note vanished, nobody adopted, and the failure surfaced only as archaeology. Now: dead address, loud refusal on the wish, with the reason.
The heartbeat age is computed by the tender's own archive db clock and read over the same connection the delivery uses. Registry stays the existence check; the heartbeat is the breath.
Tests: TestSenderLivenessAtTheDoor (4 new), full unit suite 156 passed.
@cherusk