Repository navigation
docs(source,go-bindata) update go-bindata source readme to include regex overrides for asset names - #1448
Open
erindatkinson wants to merge 2 commits into
Open
docs(source,go-bindata) update go-bindata source readme to include regex overrides for asset names#1448erindatkinson wants to merge 2 commits into
erindatkinson wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to run on a preconfigured bindata package I had, I ran into the issue that the migrations were not being run when done with code, even when they were valid with the cli runner. This was silently failing due to the continue in the
WithInstancecall failing on no regex match for otherwise valid migrations.This change updates the docs to explain better how to enable directoried asset names in lieu of just single filenames. Rather than try to update the default regex, adding the documentation on how to override to your own specific needs seems like a better option.
The example is based off the existing one, but updated based on my local tests, which worked upon compile/running:
Expand: database.go