It seems like the assets action runs after the release is created, and modifies it. This causes a problem when the action fails, because the release is then not modified as intended and we get no notification. I'm assuming we can configure things to be notified upon failure, but we should prevent the publication of incomplete releases: ideally we wouldn't create a release at all if any of the necessary actions fail, but we could also somehow revoke the release if any needed post-release-creation actions fail.
Motivating case: This run failed in the job "proto assets" at step "Upload proto release assets". (The error was Error: Resource not accessible by integration). As a result, the release had only the compressed Showcase source archives, but not the binary artifacts that would be added by later jobs (such as "binary-assets") in the action. (This particular failure instance was fixed by triggering the action with the code changes in #1589, but we don't want future action failures to result in incomplete releases.)
EDIT: Fixed a semantically significant typo!
It seems like the assets action runs after the release is created, and modifies it. This causes a problem when the action fails, because the release is then not modified as intended and we get no notification. I'm assuming we can configure things to be notified upon failure, but we should prevent the publication of incomplete releases: ideally we wouldn't create a release at all if any of the necessary actions fail, but we could also somehow revoke the release if any needed post-release-creation actions fail.
Motivating case: This run failed in the job "proto assets" at step "Upload proto release assets". (The error was
Error: Resource not accessible by integration). As a result, the release had only the compressed Showcase source archives, but not the binary artifacts that would be added by later jobs (such as "binary-assets") in the action. (This particular failure instance was fixed by triggering the action with the code changes in #1589, but we don't want future action failures to result in incomplete releases.)EDIT: Fixed a semantically significant typo!