Redraw GeoJSON features after style changes - #1732
Merged
dkhawk merged 2 commits intoAug 5, 2026
Merged
Conversation
dkhawk
force-pushed
the
fix/1050-redraw-polygon-style
branch
from
August 5, 2026 00:09
3166419 to
75f82bd
Compare
kikoso
reviewed
Aug 5, 2026
| private var mIsLayerOnMap = false | ||
| private val mFeatureMap = HashMap<GeoJsonFeature, com.google.maps.android.data.renderer.model.Feature>() | ||
| private val mModelToLegacyFeatures = HashMap<com.google.maps.android.data.renderer.model.Feature, GeoJsonFeature>() | ||
| private val mModelToLegacyFeatures = java.util.IdentityHashMap<com.google.maps.android.data.renderer.model.Feature, GeoJsonFeature>() |
Collaborator
There was a problem hiding this comment.
Can we use an import instead of the FQDN?
kikoso
reviewed
Aug 5, 2026
| ) | ||
| } | ||
|
|
||
| is com.google.maps.android.data.renderer.model.MultiGeometry -> { |
kikoso
requested changes
Aug 5, 2026
Address review feedback by replacing inline fully-qualified domain names with aliased imports at the top of the file.
Contributor
|
@kikoso Thank you for the review. All inline fully qualified class names in GeoJsonLayer.kt have been replaced with imported aliases at the top of the file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1050.
Observe legacy GeoJSON features so style and geometry changes invalidate the cached renderer model and redraw map objects with the updated values. Repeated insertion remains idempotent, removed features detach their observer, and null-geometry features remain safe across the layer lifecycle.
Multi-geometries now keep their rendered children under the parent feature, preserving complete removal and click lookup. Multi-polygons also carry their polygon style into the renderer.
Tests: