Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates frontend authentication dependencies to ChangesDependency refresh
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR updates dependency pins and aligns the shared frontend dependency version; no actionable merge-blocking risk remains, so it is merge-ready after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The pins lagged three brick trains: authkit v0.5.0 and ratelimit v0.3.0 name every refusal with a stable code, and react-auth 0.4.0 speaks the reader language through its own catalogue. The bump proved purely additive, no assertion anywhere held the old refusal shapes. react-auth 0.4.0 asks for @wordpress/i18n 6.26.0 while @wordpress/components pulled 6.25.0 transitively, so the workspace now pins one shared 6.26.0 copy, which is the shape that avoids the two-instance silent-English hazard.
Testing instructions
Run
GOWORK=off go test ./...with the compose database up. Expect 1348 tests across 30 packages.Run
fnm exec --using=26 pnpm peers check. Expect no issues, where main reports react-auth 0.4.0 wanting @wordpress/i18n 6.26.0 if you bump without the override.Run
fnm exec --using=26 pnpm why @wordpress/i18n | grep @wordpress/i18n@ | sort -u. Expect exactly one line, 6.26.0.Run
fnm exec --using=26 pnpm -r cover,pnpm typecheck,pnpm lintandpnpm lint:cssfromfrontend. Expect 430 tests and 100 percent on all four metrics.Run
fnm exec --using=26 make generateand confirmgit statusstays clean, thenfnm exec --using=26 make e2efor 37 specs.Closes #79
Summary by CodeRabbit