fix(telegram): retry transient file download failures - #246
Merged
Merged
Conversation
hcsum
marked this pull request as ready for review
September 22, 2026 14:42
Owner
|
@hcsum thanks for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Incoming Telegram media is downloaded with
node-fetch, outside the grammY Bot API retry middleware. A single transient failure therefore aborts the whole media group before it reaches OpenCode.The observed failure was an
ECONNRESETbefore TLS was established. The same path also lacked retries for HTTP429/5xxresponses and failures while reading the response body. In addition, aFetchErrorcan contain the full Telegram file URL—including the bot token—and was logged unchanged.Fix
429usingRetry-After, transient500/502/503/504responses, and common transient network errors with exponential backoff, up to three retries.codeandstatus.Tests
Regression coverage includes:
429withRetry-After;502response;The fault-proxy test helper now writes its call log before disconnecting the client, removing a CI-only race exposed while running the suite.
Verified with
npm run lint,npm run typecheck, andnpm test(161 files, 1857 tests). CI passes.