feat(tui): Complete ResourceBehaviour tier for network - #1901
Merged
Conversation
Finish migrating network.network and network.router to forward mechanical ResourceBehaviour methods to their generated companion modules, and drop subnet.rs's now-unused direct imports flagged by clippy as dead code. network.network/router had no filter_type/filter_action_name in codegenerator metadata, so Track 1 never wired their Set*ListFilters action variant and Track 2 skipped generating them. Added the metadata (codegenerator side), regenerated, and migrated both hand files. routers.rs had no handle_set_filter_action forward at all, silently relying on the trait's None default -- same latent no-op bug found earlier in security_groups.rs. Fixed as part of the migration, with tests. Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| request, | ||
| ApiRequest::Network(NetworkApiRequest::Subnet(boxreq)) | ||
| if matches!(*boxreq, NetworkSubnetApiRequest::List(_)) | ||
| ApiRequest::Network(cloud_types::NetworkApiRequest::Subnet(boxreq)) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finish migrating network.network and network.router to forward
mechanical ResourceBehaviour methods to their generated companion
modules, and drop subnet.rs's now-unused direct imports flagged by
clippy as dead code.
network.network/router had no filter_type/filter_action_name in
codegenerator metadata, so Track 1 never wired their Set*ListFilters
action variant and Track 2 skipped generating them. Added the
metadata (codegenerator side), regenerated, and migrated both hand
files.
routers.rs had no handle_set_filter_action forward at all, silently
relying on the trait's None default -- same latent no-op bug found
earlier in security_groups.rs. Fixed as part of the migration, with
tests.
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com