Skip to content

Backend: Hide Far Entities Using Entity Events instead of an all entity get - #6530

Draft
Fazfoxy wants to merge 1 commit into
hannibal002:betafrom
Fazfoxy:improvement/HideFarEntitiesEntityEvented
Draft

Fazfoxy wants to merge 1 commit into
hannibal002:betafrom
Fazfoxy:improvement/HideFarEntitiesEntityEvented

Conversation

@Fazfoxy

@Fazfoxy Fazfoxy commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

What

Testing currently, threw this PR out while I'm in the middle of booting it up
will make Improvement/Fix if the spark profile shows a noticeable performance diff but idk

exclude_from_changelog

@Fazfoxy Fazfoxy changed the title Improvement: Hide Far Entities Using Entity Events instead of an all entity get Backend: Hide Far Entities Using Entity Events instead of an all entity get Sep 11, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Detekt found 6 issues ⚠️

  • HideFarEntities.kt:12: Unused import
  • HideFarEntities.kt:19: Unused import
  • HideFarEntities.kt:20: Unused import
  • HideFarEntities.kt:25: Unused import
  • HideFarEntities.kt:26: Unused import
  • HideFarEntities.kt:32: Unused import
More Details
  • HideFarEntities.kt:12
    message: Unused import
    rule: detekt.ktlint.NoUnusedImports
    path: src/main/java/at/hannibal2/skyhanni/features/misc/HideFarEntities.kt

  • HideFarEntities.kt:19
    message: Unused import
    rule: detekt.ktlint.NoUnusedImports
    path: src/main/java/at/hannibal2/skyhanni/features/misc/HideFarEntities.kt

  • HideFarEntities.kt:20
    message: Unused import
    rule: detekt.ktlint.NoUnusedImports
    path: src/main/java/at/hannibal2/skyhanni/features/misc/HideFarEntities.kt

  • HideFarEntities.kt:25
    message: Unused import
    rule: detekt.ktlint.NoUnusedImports
    path: src/main/java/at/hannibal2/skyhanni/features/misc/HideFarEntities.kt

  • HideFarEntities.kt:26
    message: Unused import
    rule: detekt.ktlint.NoUnusedImports
    path: src/main/java/at/hannibal2/skyhanni/features/misc/HideFarEntities.kt

  • HideFarEntities.kt:32
    message: Unused import
    rule: detekt.ktlint.NoUnusedImports
    path: src/main/java/at/hannibal2/skyhanni/features/misc/HideFarEntities.kt

@github-actions github-actions Bot added the Detekt Has detekt problem label Sep 11, 2026
@Fazfoxy

Fazfoxy commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

ok this feature already acts wonkily on beta, this PR might quickly spiral...

@AverageUser125

Copy link
Copy Markdown
Contributor

Scope Creep: The Sequel

@Fazfoxy

Fazfoxy commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

Scope Creep: The Sequel

when the main branch of this feature is doing
image

whatever this image is described as, yeah.... it's scope creep time

@Fazfoxy

Fazfoxy commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

and the PR doesn't even work, amazing

@hannibal002

Copy link
Copy Markdown
Owner

while testing, please mark as draft.

@Fazfoxy
Fazfoxy marked this pull request as draft September 12, 2026 21:13
}

@HandleEvent
private fun onEntityMoveEvent(event: EntityMoveEvent<*>) {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only works if the player never moves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Detekt Has detekt problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants