Skip to content

Fix: Feast Chef Ted Filter - #6546

Open
ShanaHoshino wants to merge 3 commits into
hannibal002:betafrom
ShanaHoshino:StfuTed-update
Open

Fix: Feast Chef Ted Filter#6546
ShanaHoshino wants to merge 3 commits into
hannibal002:betafrom
ShanaHoshino:StfuTed-update

Conversation

@ShanaHoshino

@ShanaHoshino ShanaHoshino commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changelog Fixes

  • Fixed Feast Chef Ted Kernel Filter. - Shana

@github-actions

github-actions Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Changelog verification failed

Show previous issues

⚠️ Changelog verification failed ⚠️

Detected issues with the pull request description:

Body issues:

  • Author is not set in text: + Fixed Feast Chef Ted Kernel Filter
    Change should end with a full stop in text: Fixed Feast Chef Ted Kernel Filter
    Unexpected empty line after category declared

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions Bot added the Wrong Title/Changelog There is an error in the title or changelog label Sep 15, 2026
@github-actions

github-actions Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Changelog verification failed

Show previous issues

⚠️ Changelog verification failed ⚠️

Detected issues with the pull request description:

Title issues:

  • PR title does not match the expected format of 'Category: Title'

Please fix these issues. For the correct format, refer to the pull request template.

@ShanaHoshino ShanaHoshino changed the title Fixed Feast Chef Ted Filter Fix: Feast Chef Ted Filter Sep 15, 2026
@github-actions github-actions Bot removed the Wrong Title/Changelog There is an error in the title or changelog label Sep 15, 2026
hannibal002
hannibal002 requested changes Sep 17, 2026
View reviewed changes

@hannibal002 hannibal002 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog: name what the player sees, not the filter. e.g. the Kernel donation message not being hidden

Comment thread src/main/java/at/hannibal2/skyhanni/features/chat/ChatFilter.kt
"Unknown command. Type \"/help\" for help. ('uhfdsolguhkjdjfhgkjhdfdlgkjhldkjhlkjhsldkjfhldshkjf')",
"§3[SBE] §a§cUnable to download bin data. This may result in certain features not working!",
"§e[NPC] Feast Chef Ted§f: Thanks for the donation! I've added a §eKernel §fto your purse.",
"§e[NPC] Feast Chef Ted§r§f: §rThanks for the donation! I've added a §eKernel §fto your purse.",

@hannibal002 hannibal002 Sep 17, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this, it duplicates the new Feast Chef Ted filter and blocks the message even when that toggle is off

Comment thread src/main/java/at/hannibal2/skyhanni/features/chat/ChatFilter.kt
// §e[NPC] Feast Chef Ted§r§f: §rThanks for the donation! I've added a §eKernel §fto your purse.
private val masterChefMessages = listOf(
"§e[NPC] Feast Chef Ted§f: §rThanks for the donation! I've added a §eKernel §fto your purse.",
"§e[NPC] Feast Chef Ted§r§f: §rThanks for the donation! I've added a §eKernel §fto your purse.",

@hannibal002 hannibal002 Sep 17, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this list is never read, block() only uses masterChefPatterns. please delete it plus the masterchef entries in messagesMap and patternsMap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannibal002 hannibal002 hannibal002 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShanaHoshino @hannibal002