2404 stack 2 commit openapi spec - #2444
Open
correct-horse-battery-bench wants to merge 1 commit into
Open
Conversation
correct-horse-battery-bench
changed the title
correct-horse-battery-bench
force-pushed
the
2404-stack-2-commit-generated-spec
branch
from
August 18, 2026 07:44
4e9c681 to
792f942
Compare
s3inlc
approved these changes
Aug 18, 2026
correct-horse-battery-bench
marked this pull request as ready for review
August 18, 2026 14:10
The spec existed only inside the lint job, which downloaded it from a freshly started server and threw it away afterwards. Nothing in the repository showed what the API answers, so a change to a schema was invisible in review and the document that failed a lint run could not be reproduced from a checkout. openapi.json now carries the generated document (170 paths, 286 schemas), produced by `php ci/tools/generate-openapi.php --pretty` and marked linguist-generated so it collapses in review. The lint job downloads the served spec beside the committed one and compares the two first, then lints the file the repository carries. A drift fails with the diff and the command that regenerates the spec, so the committed document cannot fall behind the backend unnoticed. Both specs are normalised with jq before the comparison, so a difference in key order or formatting is not reported as drift.
correct-horse-battery-bench
force-pushed
the
2404-stack-2-commit-generated-spec
branch
from
August 18, 2026 14:37
792f942 to
c300836
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check in generated openapi spec and make sure it is up to date.