Do not create template entities when action validation fails during setup - #180183
Merged
balloob merged 1 commit intoAug 25, 2026
Merged
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents template entities from being created when action validation fails.
Changes:
- Makes script validation return success status.
- Filters invalid YAML, trigger, and config-entry entities.
- Adds coverage for all action-enabled template platforms.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/template/helpers.py |
Skips entity creation after validation failure. |
tests/components/template/conftest.py |
Adds shared invalid-action test helpers. |
tests/components/template/test_alarm_control_panel.py |
Tests alarm panel actions. |
tests/components/template/test_button.py |
Tests button actions. |
tests/components/template/test_cover.py |
Tests cover actions. |
tests/components/template/test_fan.py |
Tests fan actions. |
tests/components/template/test_light.py |
Tests light actions. |
tests/components/template/test_lock.py |
Tests lock actions. |
tests/components/template/test_number.py |
Tests number actions. |
tests/components/template/test_select.py |
Tests select actions. |
tests/components/template/test_switch.py |
Tests switch actions. |
tests/components/template/test_update.py |
Tests update actions. |
tests/components/template/test_vacuum.py |
Tests vacuum actions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
balloob
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
When script validation fails, template integration will silently remove the action and still create the entity. This changes the behavior, now an error is logged and the entity is not created.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: