Clamp out-of-range SystemTime instead of panicking in date headers#232
Open
SAY-5 wants to merge 1 commit into
Open
Clamp out-of-range SystemTime instead of panicking in date headers#232SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230.
From<SystemTime> for HttpDateis where every date header conversion (Date,LastModified,Expires,IfModifiedSince,IfUnmodifiedSince,RetryAfter::date,IfRange::date, andis_modified) ends up, andhttpdatepanics there on aSystemTimebefore the Unix epoch or past year 9999. A pre-1970 file mtime handed toLastModified::from(metadata.modified()?)aborts the request handler even though the signature accepts anySystemTime.This clamps the value to the representable range before the conversion so those calls return a date instead of panicking. Happy to switch to documenting the panic instead if you would rather keep the current behavior.