Test/ci echidna hypatia fix - #338
Open
hyperpolymath wants to merge 3 commits into
Open
Conversation
corpus_loader.jl (landed in #198 saturation+typing) does `using JSON` + `JSON.parse(raw)`, but Project.toml had only JSON3. Result: every train-from-corpus invocation fails with `Package JSON not found`. Add JSON to deps (vs rewriting JSON.parse → JSON3.read; JSON3 returns lazy structures and the call-site logic expects JSON.jl semantics). Discovered when launching the first owner-authorised GNN training run 2026-06-02 (stages 3+4 failed cleanly). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Update hypatia-scan-reusable SHA to 6cd3772824e59c8c9affeab66061e25383544242 - Increase CodeQL timeout from 15 to 60 minutes Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Triggers CI to verify: - CodeQL timeout increased to 60 minutes - Hypatia SHA updated to 6cd3772824e59c8c9affeab66061e25383544242 Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review ✅ ApprovedUpdates the Hypatia workflow SHA, adds CodeQL timeouts, and includes the missing JSON dependency in
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Type of change
How has this been verified?
Checklist
git commit -S).SPDX-License-Identifier(code/configMPL-2.0,prose
CC-BY-SA-4.0); I did not relicense existing files.Notes for reviewers
Summary by Gitar
timeout-minutesin.github/workflows/hypatia-scan.yml.github/workflows/codeql.ymland addedTEST_CI_ECHIDNA.mdThis will update automatically on new commits.