IBX-12202: Fixed error on Date field with missing timestamp key - #797
Open
mateuszdebinski wants to merge 3 commits into
Open
IBX-12202: Fixed error on Date field with missing timestamp key#797mateuszdebinski wants to merge 3 commits into
mateuszdebinski wants to merge 3 commits into
Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
August 5, 2026 11:45
konradoboza
reviewed
Aug 5, 2026
bnowak
approved these changes
Aug 6, 2026
mikadamczyk
reviewed
Aug 6, 2026
tbialcz
approved these changes
Aug 6, 2026
alongosz
reviewed
Aug 6, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
DateConverter::toStorageValue() assumed $value->data always contains a 'timestamp' key. When only 'timestring' was set (e.g. default value built from a field definition with DEFAULT_CURRENT_DATE), this caused an undefined array key error. The value is now derived from 'timestring' when 'timestamp' is missing, and null is used as a fallback.
I wasn't sure if we should leave null here like in this PR #757.
For QA:
Documentation: