Skip to content

Change search_buffer_visited_set_ default from false to true #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuejiaointel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change search_buffer_visited_set_ default from false to true #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions include/svs/index/vamana/search_params.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ struct VamanaSearchParameters {
///
/// The visited set tracks whether candidates the distance between a query and a
/// candidate has already been computed. Enabling this feature generally improves
/// performance in the high-recall or high-neighbor regime.
bool search_buffer_visited_set_ = false;
/// performance in the high-recall or high-neighbor regime. Defaults to `true`:
/// regression testing (48 configs, k=100, recall 0.90-0.95) showed a consistent
/// 1.2x-1.4x QPS gain with no recall cost and no regressions.
bool search_buffer_visited_set_ = true;

/// @brief The number of iterations ahead to prefetch candidates.
size_t prefetch_lookahead_ = 4;
Expand Down
Loading