Skip to content

[terraform/aws] Create gp3 storage class, add release notes - #1629

Merged
barroco merged 1 commit into
interuss:masterfrom
Orbitalize:add_storage_class
Aug 13, 2026
Merged

[terraform/aws] Create gp3 storage class, add release notes#1629
barroco merged 1 commit into
interuss:masterfrom
Orbitalize:add_storage_class

Conversation

@the-glu

@the-glu the-glu commented Aug 12, 2026

Copy link
Copy Markdown
Member

#1606 changed the default storage class for AWS clusters, but the gp3 storage class is not available by default in EKS clusters.

This PR adds a mechanism to terraform to create it. It can be opted out of, should someone with an existing cluster have created it by other means, e.g. manually.

Release notes have also been updated with information about the potential migration step needed.

This has been tested with a fresh cluster and a PVC that has been successfully provisioned.

@mickmis mickmis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been tested with a fresh cluster and a PVC that has been successfully provisioned.

Have you tested the behavior on an existing cluster?

@the-glu

the-glu commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

Have you tested the behavior on an existing cluster?

Not explicitly, but as terraform maintain the state, I think it should be fine even if applied later. Especially as cluster from users that already have a configuration / copied example configuration will stay on gp2.

I tried to delete / recreate that part on my test cluster and it worked.

@mickmis

mickmis commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Have you tested the behavior on an existing cluster?

Not explicitly, but as terraform maintain the state, I think it should be fine even if applied later. Especially as cluster from users that already have a configuration / copied example configuration will stay on gp2.

I tried to delete / recreate that part on my test cluster and it worked.

@barroco does that sound OK to you? I'm not confident enough on those tech to be sure or not. However for sure we should avoid deployment issues when users are upgrading.

@barroco

barroco commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Have you tested the behavior on an existing cluster?

Not explicitly, but as terraform maintain the state, I think it should be fine even if applied later. Especially as cluster from users that already have a configuration / copied example configuration will stay on gp2.
I tried to delete / recreate that part on my test cluster and it worked.

@barroco does that sound OK to you? I'm not confident enough on those tech to be sure or not. However for sure we should avoid deployment issues when users are upgrading.

Since the change is only creating resources, it would only fail if resources with same names were added manually previously. So I agree with @the-glu. If a user had created those resources, they can use the flag as documented in the release note.

Though, migrating from gp2 to gp3 is out of scope of this change and is left to users to organize. Guidance may be provided but I would expect an issue to be opened specifically to request it.

Comment thread NEXT_RELEASE_NOTES.md Outdated
@the-glu
the-glu force-pushed the add_storage_class branch from c4ca181 to add05c8 Compare August 12, 2026 13:36
@the-glu
the-glu requested a review from barroco August 12, 2026 13:47
Comment thread deploy/infrastructure/dependencies/terraform-aws-kubernetes/variables.gen.tf Outdated
Comment thread deploy/infrastructure/dependencies/terraform-aws-kubernetes/storage.tf Outdated
@the-glu
the-glu force-pushed the add_storage_class branch from 560b078 to e523d31 Compare August 13, 2026 12:19
@the-glu
the-glu force-pushed the add_storage_class branch from e523d31 to f5359e6 Compare August 13, 2026 12:23
@mickmis mickmis changed the title [terrafrom/aws] Create gp3 storage class, add release notes [terraform/aws] Create gp3 storage class, add release notes Aug 13, 2026
@barroco

barroco commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Can you please confirm you tested it again ?

@the-glu

the-glu commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

Can you please confirm you tested it again ?

Yes, tested with a new cluster and default config and works as expected:

image

@barroco
barroco merged commit 4c729c3 into interuss:master Aug 13, 2026
12 checks passed
@barroco
barroco deleted the add_storage_class branch August 13, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants