feat(angular): update lazy and standalone import paths - #1881
Conversation
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Awesome work! And good job finding that vscode import issue too!
|
@ShaneK Given this change, we might want to consider what I did in this PR (#1874) for Ionic v9. We would need to adjust settings.json for both the standalone and module templates to account for the updated import paths. Alternatively, if viable, it might be worth considering publishing the Ionic library itself (currently @ionic/angular) as independent packages for standalone and modules. This would completely avoid the need to manually exclude paths in the editor. Additionally, since some users might prefer other code editors, they would have to figure out an equivalent configuration for their setup. As far as I know, there is currently no reference to this VS Code configuration in the official documentation, so addressing this—either by splitting the package or documenting the editor settings—would prevent a lot of friction. |
|
If needed, I'd be happy to open a PR to adjust the settings.json for major v9. |
|
@luisbytes was it not properly adjusted in the last commit? f4dd16e Or was something missed? |
|
@ShaneK Yes, a couple of things were missed:
If you'd like, I can open a PR to get both templates fully aligned. |
|
@luisbytes That would be great, I'd appreciate it! Thanks for bringing this to our attention! |
* feat(many): migrate react-vite, vue-vite, and angular starters to Ionic v9 (#1880) * feat(react-vite): migrate starters to react router 6 * feat(vue-vite): migrate starters to ionic v9 and vue router 5 * feat(angular): migrate starters to ionic v9, angular 22, zoneless signals, and vitest * ci: bump test matrix to node 22 for angular 22 starters * fix(angular): capitalize sidemenu folder route so page title renders Inbox not inbox in the same way the other test apps do it * feat(angular): update lazy and standalone import paths (#1881) * feat(many): target @ionic/* ^9.0.0 and finalize starters for the v9 release * refactor(angular): drop redundant provideZonelessChangeDetection from both Angular starters --------- Co-authored-by: OS-jacobbell <228905018+OS-jacobbell@users.noreply.github.com>
3 participants
Description
Ionic Framework v9 makes standalone components the default for Angular and changes the import paths:
@ionic/angular->@ionic/angular/lazyand@ionic/angular/standalone->@ionic/angular. This PR updates the starter apps to use these new import paths.Change Type
Platforms Affected
Notes / Comments
The
@ionic/angulardev build version specified inpackage.jsonhas been bumped to a build with the import path updates. These will need to be changed to a 9.x build before merging major-9.0 branch into main.