Skip to content

fix: fix for missing xsl import that was being ignored - #7

Merged
at88mph merged 3 commits into
mainfrom
missing-import-fix
Jul 30, 2026
Merged

at88mph merged 3 commits into
mainfrom
missing-import-fix

Conversation

@at88mph

@at88mph at88mph commented Jul 28, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

  • Import for testsVOResource.xsl-v1_0.xsl declared but doesn't exist. Fetched from legacy rofr.ivoa.net.
  • Renamed to better fit with other declarations.
  • No longer ignores XSL (or missing checkVOResource.xsl) errors
    • Returned error message has (hopefully) meaningful check to resolve the error

@at88mph
at88mph requested a review from msdemlei July 28, 2026 19:57

@msdemlei msdemlei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does what it should, but I think we should re-think the slient fall-back to skipping the XSL tests. If you're as unsure about the implications as I am, I'd say we should fail hard if resources are missing. A validator that might (for instance) pass a service on a local installation (where the file is missing) and then fails on the RofR itself (where the file is there) is I think more confusion than a clean, hard failure (in particular if we explain how to fix it).

Anyway, let's merge this and worry about the silent fallback later.

@at88mph

at88mph commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

Right, good point. There is no rush for this, and I need to fix some conflicts anyway, so I will resolve to fail with a friendly message in that case.

@at88mph

at88mph commented Jul 30, 2026 •

Copy link
Copy Markdown
Collaborator Author

Good. I created a separate XsltError to handle this. Transform/XSL errors, or just a missing checkVOResource.xsl will no longer return an empty error array. It was actually happening in two places, so both should be plugged now.

@at88mph
at88mph merged commit dc827d4 into main Jul 30, 2026
3 checks passed
@at88mph
at88mph deleted the missing-import-fix branch July 30, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants