fix: fix for missing xsl import that was being ignored - #7
Conversation
msdemlei
left a comment
There was a problem hiding this comment.
I think this does what it should, but I think we should re-think the slient fall-back to skipping the XSL tests. If you're as unsure about the implications as I am, I'd say we should fail hard if resources are missing. A validator that might (for instance) pass a service on a local installation (where the file is missing) and then fails on the RofR itself (where the file is there) is I think more confusion than a clean, hard failure (in particular if we explain how to fix it).
Anyway, let's merge this and worry about the silent fallback later.
|
Right, good point. There is no rush for this, and I need to fix some conflicts anyway, so I will resolve to fail with a friendly message in that case. |
…ly empty error array was returned
|
Good. I created a separate |
Changes
testsVOResource.xsl-v1_0.xsldeclared but doesn't exist. Fetched from legacyrofr.ivoa.net.