Conversation
…tions (jbr7rr#194) Notification parsing: - field-size table and up-front length check - prevent crashes; short payload keeps the state and drops all fields. - validate bolus/basal/reservoir values, verify patch ID. - handle 1- and 2-byte notifications: take the state byte. Delivery state: - finalize the running basal and record a suspend whenever the patch state is halted - don't re-emit notifications on every sync. Co-authored-by: claude and gpt
# Conflicts: # MedtrumKit/PumpManager/PeripheralManager.swift
Contributor
Author
|
merge conflicts resolved |
|
Both issues didnt occur yesterday when my pod ran dry. Basal rate got recorded as 0 even thou algo said non-zero, no crash. So for me fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #194
Notification parsing:
Delivery state:
there will be minor conflicts with do not retain a cycle of strong references preventing CentralManager from deallocating #192 - I'll update either of the PRs after one of them is merged