Consolidate the shared error state - #114
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR consolidates error UI by removing the duplicate ErrorState implementation from ErrorBoundary and reusing the shared components/ErrorState.jsx for both the app boundary and the extension SDK export surface.
Changes:
ErrorBoundarynow renders the sharedErrorStatecomponent instead of an inline fallback UI.- The SDK re-exports
ErrorStatefrom the canonical module andErrorBoundaryas its default export.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/plugins/sdk/index.js | Switches SDK exports to source ErrorState from the canonical component module. |
| frontend/src/components/ErrorBoundary.jsx | Removes the duplicate ErrorState implementation and delegates fallback rendering to components/ErrorState.jsx. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate the shared error state
Two error-state implementations were one too many, especially on the path meant to rescue the UI from failures. This cleanup makes the existing shared
ErrorStatecomponent the single presentation used by both the application boundary and extension SDK. The boundary retains its reporting, retry, and route-reset behavior while delegating the rendered fallback to the canonical component. Keeping one implementation avoids import ambiguity and prevents the two versions from drifting apart later.Technical changes
ErrorBoundarynow renderscomponents/ErrorState.jsxand removes its duplicate namedErrorStateimplementation.ErrorBoundaryandErrorState, withErrorStatenow sourced from the canonical component module.[skip version]so merging it intodevdoes not advance the already-finalized 1.7.125 release number.