Skip to content

Breaking changes in 8.0.0 #863

Description

@jpdillingham

Breaking Changes

#861 Changes the shape of the Search class

The existing SearchText property has been dropped, and Query has been added. The Query property is assigned the SearchQuery object that was passed to the client when the search was created. Instead of Search.SearchText, use Search.Query.SearchText. Additionally a Scope property has been added and is assigned the original SearchScope passed into the client. This shouldn't break anything.

#862 Default TransferOptions DisposeInput/OutputStreamOnCompletion options to true instead of false

This change defaults these two parameters for the TransferOptions constructor to true instead of false. This will cause any existing code that's disposing input or output streams either explicitly or within a using block to throw due to the streams already having been disposed. To fix this, either stop disposing streams in application logic, or explicitly set these options to false to force the old behavior.

Applications that were not previously disposing streams and had not explicitly set the options to true will enjoy a resource leak fix.

#870 Remove AddUserAsync()

This was deprecated some time last year in favor of WatchUserAsync(). Fix any broken code by moving to that.

#866/#872 Refactor UploadAsync() and DownloadAsync()

This refactoring is almost entirely internal, with the only functional change being that the final Progress event for the transfer is no longer sent with the state Completed | Succeeded, but rather InProgress. This change was made because the Transfer was being advertised as having completed without having raised the StateChanged event/calling the delegate, and the previous behavior was unexpected.

Applications that relied on the transfer state from the final progress event to terminate transfers will need to begin also handling state events to capture the same data.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions