fix(e2e): share-verification probe reads rendered state and the full hash (#1279) - #1280
Merged
Merged
Conversation
…he full hash (#1279) Two defects in the deep-mode probe made it fail on every deployment: 1. `not.toContain("Invalid hash")` / `not.toContain("Not found")` ran against the whole verify-page HTML, which ships its translation dictionary for hydration, so both strings are present on every verified page. 2. The hash pattern `([0-9a-f]{8}|[0-9a-f]{16}|[0-9a-f]{32})` tried the shortest alternative first, so a 32-character hash was captured as its first 8 characters and the probe verified a hash that does not exist. `probe-html.ts` (pure, unit-tested) matches labels as rendered text nodes and extracts the longest hash with a boundary. The probe attaches the response body to disk and to the report when an assertion on it fails, so the transient seen once after the v2.29.5 deploy is diagnosable next time. Verified against production v2.29.5: six of six deep scenarios pass. Fixes #1279 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NnfhmLrHFuLNnHFKcZ3f7m
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
juan294
enabled auto-merge (squash)
September 3, 2026 19:47
Bundle Size Report
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profile.share-verification(deep mode only) failed on every deployment for two reasons, found by/prodplaybook v2.29.5:{8}before{32}and captured the first 8 characters of the 32-character hash, then verified a hash that does not exist.Changes
e2e/helpers/probe-html.ts(new, pure):hasRenderedTextmatches a label only as a text node between tags;verifyHashFromHtmlextracts the longest hash with a trailing boundary. 9 unit tests, including the dictionary-string and 8-of-32 negative cases.assertShareVerificationuses both, and on failure writes the response body to the test output directory and attaches it to the report.Verification
Fixes #1279
🤖 Generated with Claude Code
https://claude.ai/code/session_01NnfhmLrHFuLNnHFKcZ3f7m