Fix stale async handler after timeout by mr-j0nes · Pull Request #224 · karastojko/mailio

mr-j0nes · 2026-05-21T17:39:27Z

Cancel socket and drain pending handlers before throwing in wait_async(), preventing use-after-free when dialog is copied

Fix: #223, maybe #222 too

Cancel socket and drain pending handlers before throwing in wait_async(), preventing use-after-free when dialog is copied Fix: karastojko#223, maybe karastojko#222 too

Spixmaster

The CMake issues are critical. Currently, the tests do not even build.

The other stuff is from clang-tidy. You should really use it.

Spixmaster · 2026-05-25T04:19:29Z

Tests are passing on my side.

Spixmaster · 2026-05-25T04:28:39Z

Issue #222 was not fixed by this.

- test/CMakeLists.txt: remove unnecessary Boost::system dependency (karastojko#212) - Add explicit on TestServer constructor - Add missing includes: unit_test_suite, tools/old/interface, steady_timer, system/error_code, string - Use explicit curly braces on all if statements - Fix unused return value from socket_->close(ec)

mr-j0nes · 2026-05-25T11:20:25Z

All issues in comments have been resolved. Let me know if I missed anything..

Spixmaster · 2026-05-25T12:25:14Z

@@ -12,12 +12,17 @@ copy at http://www.freebsd.org/copyright/freebsd-license.html.
 #define BOOST_TEST_MODULE dialog_test

 #include <boost/test/unit_test.hpp>


#include <boost/test/unit_test.hpp> is not needed.

Spixmaster · 2026-05-25T12:37:42Z

Thank you very much. You can mark the recommendations as resolved when you considered them to distinguish between open and closed recommendations.

- Remove unused `<boost/asio.hpp>`, add explicit includes - Add missing `<chrono>`, `<string>`, `<cstddef>`, `<boost/assert.hpp>` - Add `const` to `error_code` lambda parameters - Add `explicit` on `TestServer` constructor - Use explicit curly braces on all if statements - Check `socket_->close()` error code with `BOOST_CHECK` instead of

mr-j0nes · 2026-05-25T15:16:01Z

Ok, just pushed a new commit with all new comments addressed.
Out of curiosity, how do you run clang-tidy? I have installed it and run it on the test and got nothing.

clang-tidy --version
Ubuntu LLVM version 14.0.0
  
  Optimized build.
  Default target: x86_64-pc-linux-gnu
  Host CPU: tigerlake

Spixmaster · 2026-05-25T15:24:30Z

I depends on the configuration file.

--config-file=~/clang/clang-tidy.yaml

This is my current clang-tidy.yaml.

---
# "google-readability-namespace-comments" needs to be removed as it is an alias for "llvm-namespace-comment" and
# thus prevents fixing.
Checks: "*, -abseil-string-find-str-contains, -altera-id-dependent-backward-branch, -altera-unroll-loops, -bugprone-branch-clone,
  -bugprone-easily-swappable-parameters, -bugprone-suspicious-missing-comma, -bugprone-unused-raii, -cert-err58-cpp, -cppcoreguidelines-avoid-magic-numbers,
  -fuchsia-default-arguments-calls, -fuchsia-default-arguments-declarations, -fuchsia-overloaded-operator, -fuchsia-statically-constructed-objects,
  -google-readability-function-size, -google-readability-namespace-comments, -google-readability-todo, -hicpp-function-size,
  -hicpp-named-parameter, -hicpp-use-auto, -llvm-else-after-return, -llvm-include-order, -llvmlibc-callee-namespace, -llvmlibc-implementation-in-namespace,
  -llvmlibc-inline-function-decl, -llvmlibc-restrict-system-libc-headers, -misc-no-recursion, -modernize-loop-convert, -modernize-use-auto,
  -modernize-use-designated-initializers, -modernize-use-nodiscard, -modernize-use-trailing-return-type, -openmp-exception-escape,
  -performance-inefficient-string-concatenation, -readability-else-after-return, -readability-function-cognitive-complexity,
  -readability-function-size, -readability-identifier-length, -readability-magic-numbers, -readability-named-parameter"
FormatStyle: ${XDG_CONFIG_HOME}/clang/clang-format.yaml

In general, it is useful to integrate linter (gives recommendations) and formatter into your editor. For me, it is Vim. You might be interested in at least the tools here, https://github.com/dense-analysis/ale/blob/master/supported-tools.md, or even the programme itself, https://github.com/dense-analysis/ale.

clang-format is my favourite formatter for C++.

Spixmaster

The return type of socket_->cancel(ec); in src/dialog.cpp should really be addressed.

Spixmaster · 2026-05-26T02:12:02Z

I just tested this pull request.

normal mailio: my server can send e-mail, my computer cannot

this pull request: My computer sent one e-mail. I did not test my server.

A good first sign.

- src/dialog.cpp: suppress bugprone-unused-return-value for socket_->cancel() calls by assigning to std::ignore - test/test_dialog_stale_handler.cpp: use return value of socket_->close() in BOOST_CHECK instead of out-param

mr-j0nes · 2026-05-26T06:34:47Z

I am glad. Sent out the fix for the latest comments. Some of them where false positive though. The ec value cannot be defined as const as cancel() accepts a reference. I used std::ignore() to silence "The value returned by this function should not be disregarded;", as we are throwing anyway..

mr-j0nes · 2026-05-26T08:57:32Z

I depends on the configuration file.

--config-file=~/clang/clang-tidy.yaml

This is my current clang-tidy.yaml.

---
# "google-readability-namespace-comments" needs to be removed as it is an alias for "llvm-namespace-comment" and
# thus prevents fixing.
Checks: "*, -abseil-string-find-str-contains, -altera-id-dependent-backward-branch, -altera-unroll-loops, -bugprone-branch-clone,
  -bugprone-easily-swappable-parameters, -bugprone-suspicious-missing-comma, -bugprone-unused-raii, -cert-err58-cpp, -cppcoreguidelines-avoid-magic-numbers,
  -fuchsia-default-arguments-calls, -fuchsia-default-arguments-declarations, -fuchsia-overloaded-operator, -fuchsia-statically-constructed-objects,
  -google-readability-function-size, -google-readability-namespace-comments, -google-readability-todo, -hicpp-function-size,
  -hicpp-named-parameter, -hicpp-use-auto, -llvm-else-after-return, -llvm-include-order, -llvmlibc-callee-namespace, -llvmlibc-implementation-in-namespace,
  -llvmlibc-inline-function-decl, -llvmlibc-restrict-system-libc-headers, -misc-no-recursion, -modernize-loop-convert, -modernize-use-auto,
  -modernize-use-designated-initializers, -modernize-use-nodiscard, -modernize-use-trailing-return-type, -openmp-exception-escape,
  -performance-inefficient-string-concatenation, -readability-else-after-return, -readability-function-cognitive-complexity,
  -readability-function-size, -readability-identifier-length, -readability-magic-numbers, -readability-named-parameter"
FormatStyle: ${XDG_CONFIG_HOME}/clang/clang-format.yaml

In general, it is useful to integrate linter (gives recommendations) and formatter into your editor. For me, it is Vim. You might be interested in at least the tools here, https://github.com/dense-analysis/ale/blob/master/supported-tools.md, or even the programme itself, https://github.com/dense-analysis/ale.

clang-format is my favourite formatter for C++.

It would be good to include into the repo your clang-tidy.yaml and clang-format.yaml, to prevent going back and forward with PRs

Spixmaster · 2026-05-27T05:58:48Z

I depends on the configuration file.
--config-file=~/clang/clang-tidy.yaml
This is my current clang-tidy.yaml.

---
# "google-readability-namespace-comments" needs to be removed as it is an alias for "llvm-namespace-comment" and
# thus prevents fixing.
Checks: "*, -abseil-string-find-str-contains, -altera-id-dependent-backward-branch, -altera-unroll-loops, -bugprone-branch-clone,
  -bugprone-easily-swappable-parameters, -bugprone-suspicious-missing-comma, -bugprone-unused-raii, -cert-err58-cpp, -cppcoreguidelines-avoid-magic-numbers,
  -fuchsia-default-arguments-calls, -fuchsia-default-arguments-declarations, -fuchsia-overloaded-operator, -fuchsia-statically-constructed-objects,
  -google-readability-function-size, -google-readability-namespace-comments, -google-readability-todo, -hicpp-function-size,
  -hicpp-named-parameter, -hicpp-use-auto, -llvm-else-after-return, -llvm-include-order, -llvmlibc-callee-namespace, -llvmlibc-implementation-in-namespace,
  -llvmlibc-inline-function-decl, -llvmlibc-restrict-system-libc-headers, -misc-no-recursion, -modernize-loop-convert, -modernize-use-auto,
  -modernize-use-designated-initializers, -modernize-use-nodiscard, -modernize-use-trailing-return-type, -openmp-exception-escape,
  -performance-inefficient-string-concatenation, -readability-else-after-return, -readability-function-cognitive-complexity,
  -readability-function-size, -readability-identifier-length, -readability-magic-numbers, -readability-named-parameter"
FormatStyle: ${XDG_CONFIG_HOME}/clang/clang-format.yaml

In general, it is useful to integrate linter (gives recommendations) and formatter into your editor. For me, it is Vim. You might be interested in at least the tools here, https://github.com/dense-analysis/ale/blob/master/supported-tools.md, or even the programme itself, https://github.com/dense-analysis/ale.
clang-format is my favourite formatter for C++.

It would be good to include into the repo your clang-tidy.yaml and clang-format.yaml, to prevent going back and forward with PRs

I have not authority over this project. Linter and formatter are something the owner decides.

Spixmaster · 2026-05-27T06:09:05Z

I have never seen std::ignore. Good job. Indeed, clang-tidy has a false positive regarding boost::system::error_code ec.

karastojko · 2026-06-25T05:06:40Z

The 0.26 is released, so I will take a look of this. Thanks for the effort.

Fix stale async handler after timeout

2eaf050

Cancel socket and drain pending handlers before throwing in wait_async(), preventing use-after-free when dialog is copied Fix: karastojko#223, maybe karastojko#222 too

mr-j0nes mentioned this pull request May 22, 2026

SegFault on imap connections with timeout #220

Open

Spixmaster suggested changes May 25, 2026

View reviewed changes

Spixmaster reviewed May 26, 2026

View reviewed changes

Comment thread src/dialog.cpp Outdated

Comment thread src/dialog.cpp

Comment thread src/dialog.cpp

Comment thread src/dialog.cpp Outdated

Comment thread test/test_dialog_stale_handler.cpp

Comment thread test/test_dialog_stale_handler.cpp Outdated

Fix clang-tidy warnings for unused return values

af86594

- src/dialog.cpp: suppress bugprone-unused-return-value for socket_->cancel() calls by assigning to std::ignore - test/test_dialog_stale_handler.cpp: use return value of socket_->close() in BOOST_CHECK instead of out-param

Spixmaster approved these changes May 27, 2026

View reviewed changes

		@@ -12,12 +12,17 @@ copy at http://www.freebsd.org/copyright/freebsd-license.html.
		#define BOOST_TEST_MODULE dialog_test

		#include <boost/test/unit_test.hpp>

Conversation

mr-j0nes commented May 21, 2026

Uh oh!

Spixmaster left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Spixmaster commented May 25, 2026

Uh oh!

Spixmaster commented May 25, 2026

Uh oh!

mr-j0nes commented May 25, 2026

Uh oh!

Uh oh!

Spixmaster May 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Spixmaster commented May 25, 2026

Uh oh!

mr-j0nes commented May 25, 2026

Uh oh!

Spixmaster commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Spixmaster left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Spixmaster commented May 26, 2026

Uh oh!

mr-j0nes commented May 26, 2026

Uh oh!

mr-j0nes commented May 26, 2026

Uh oh!

Spixmaster commented May 27, 2026

Uh oh!

Spixmaster commented May 27, 2026

Uh oh!

karastojko commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Spixmaster commented May 25, 2026 •

edited

Loading

Spixmaster left a comment •

edited

Loading